Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add test for decimal rowNumber test automation (See #1106) #1114

Merged
merged 1 commit into from
May 29, 2024

Conversation

gnarf
Copy link
Contributor

@gnarf gnarf commented May 29, 2024

Thanks for adding that data @howard-e - here is the test case for decimal rowNumber in automation.

I did test this with a reverted #1105

 FAIL  tests/integration/automation-scheduler.test.js (24.564 s)
  ● Automation controller › should update job results with decimal presentationNumber

    expect(received).toEqual(expected) // deep equality

    Expected: "ZmE3YeyIyIjoiMTYwIn0zFmMD"
    Received: "YzM3MeyIyIjoiMTYwIn0TFmNj"

      637 |             expect(testResults.length).toEqual(testResultsNumber + 1);
      638 |             testResults.forEach(testResult => {
    > 639 |                 expect(testResult.test.id).toEqual(selectedTest.id);
          |                                            ^
      640 |                 expect(testResult.atVersion.name).toEqual(
      641 |                     at.atVersions[0].name
      642 |                 );

      at toEqual (tests/integration/automation-scheduler.test.js:639:44)
          at Array.forEach (<anonymous>)
      at forEach (tests/integration/automation-scheduler.test.js:638:25)
      at Object.sessionAgentDbCleaner (tests/util/api-server.js:62:5)
      at Object.<anonymous> (tests/integration/automation-scheduler.test.js:571:9)

@gnarf gnarf requested a review from howard-e May 29, 2024 18:13
Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Hopefully we can continue to make testing new scenarios easier.

@howard-e howard-e merged commit 347bf07 into development May 29, 2024
2 checks passed
@howard-e howard-e deleted the test-decimal-rownumber branch May 29, 2024 19:09
@howard-e howard-e mentioned this pull request Jun 12, 2024
howard-e added a commit that referenced this pull request Jun 12, 2024
June 12, 2024 Release

Issues addressed:
* #1111, addresses #1107
* #1114, addresses #1106
* #1112, addresses #966
* #1127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants