Feat: Enable automation support for VoiceOver/Safari/MacOS

[gnarf]

No description provided.

[howard-e]

Confirmed this allows VO and Safari tests to be queued up and ran as expected. Great stuff!

I left a minor question inline about a logging variable.

However, the main reason I think a 2nd look should be had here is because the prompt to trigger automation when an eligible report is created seems to be missing. I would have expected to be able to simply select that when creating a VoiceOver report now. In fact, it is also missing for when I'm creating an NVDA report as well. I confirmed it still popped up on development as shown in the screenshot but didn't on this branch.

[howard-e]

In an effort to limit the amount of files changed per PR whenever a mock is involved, may be worth acknowledging that a lot of the mock data used throughout is structurally very similar and also use the same data in a lot of instances.

Thinking using a construction of "pieces" of mock data may be helpful so only a single location has to change to make it easier for future reviews.

This can be discussed outside of this PR of course and not expecting any change here.

[howard-e]

I don't see logging being passed in any calls. How is logging being used?

[gnarf]

it's not, but it's clever - if you having trouble figuring out why the SQL query isn't working passing logging: console.log will dump the build SQL query - I can remove it but I wanted to point it out - glad you caught it

[howard-e]

Yep you could remove it, but very helpful to note down!

[gnarf]

However, the main reason I think a 2nd look should be had here is because the prompt to trigger automation when an eligible report is created seems to be missing. I would have expected to be able to simply select that when creating a VoiceOver report now. In fact, it is also missing for when I'm creating an NVDA report as well. I confirmed it still popped up on development as shown in the screenshot but didn't on this branch.

Nice catch! I can take a quick look, but it's likely that the test report isn't passing the key property for at/brower -- Any chance you could give me more direct instructions where that popup shows up and I'll try to carve out 30 minutes a little later today to hunt this down.

[howard-e]

Any chance you could give me more direct instructions where that popup shows up and I'll try to carve out 30 minutes a little later today to hunt this down.

@gnarf sure! On development, it pops up anytime I'm creating a Test Plan Report which uses NVDA as the AT. So in 2 cases currently:

1. On Test Queue page, as an admin, use the Add Test Plans to the Test Queue section to add a report to the queue which uses NVDA for the AT option.
2. On the Data Management page, as an admin, use the Test Plan Report status dialog up to add any report which is missing and uses the NVDA AT.

[gnarf]

a659c83 should fix the issue with the add and run popup:

[howard-e]

Changes look good!

Although the test failure is quite puzzling to me (because I can't get it to fail locally). It may be worth figuring out but the assertion will have to be updated to 1 anyways because of #1097 changes recently being included in development that do away with the <span class=sr-only>.

[gnarf]

Although the test failure is quite puzzling to me (because I can't get it to fail locally). It may be worth figuring out but the assertion will have to be updated to 1 anyways because of #1097 changes recently being included in development that do away with the <span class=sr-only>.

The test that was failing was on the merged branch, so it made sense I just needed to update for the new assumptions.

[howard-e]

Thanks for addressing the feedback!