Add type-ahead to assign tester dropdown #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howard-e
reviewed
May 15, 2024
| @@ -113,9 +113,33 @@ const AssignTesterDropdown = ({ | |||
| const clearAriaLiveRegion = () => { | |||
| setAlertMessage(''); | |||
| }; | |||
|
|
|||
| const handleKeyDown = event => { | |||
|
|
||
| const handleKeyDown = event => { | ||
| const { key } = event; | ||
| if (key.match(/[a-z]/)) { |
There was a problem hiding this comment.
Suggested change
| if (key.match(/[a-z]/)) { | |
| if (key.match(/[0-9a-zA-Z]/)) { |
While there are none currently tracked by the app, I've come to find out GitHub usernames can begin with a number, so just to be safe. Uppercase is there as well in case one is holding Shift or CapsLock is enabled. It seems to also align with browsers' native behavior for <select>
Merged
howard-e
added a commit
that referenced
this pull request
May 28, 2024
Issues addressed: * #1105, addresses w3c/aria-at#1070 * #1053, addresses w3c/aria-practices#2971 * #1097, addresses #977 * #1095, addresses #991 * #1093, addresses #934 * #1000, addresses #818 * #1089, addresses #992 * #1067, addresses #993 * #1056, addresses w3c/wai-aria-practices#212 --------- Co-authored-by: alflennik <[email protected]> Co-authored-by: Paul Clue <[email protected]> Co-authored-by: Mx Corey Frang <[email protected]> Co-authored-by: Mx. Corey Frang <[email protected]> Co-authored-by: Erika Miguel <[email protected]> Co-authored-by: Mike Pennisi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #991
This pull request updates the assign tester menu to support type-ahead.