Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test plan version history page is incomplete #761

Closed
mcking65 opened this issue Aug 30, 2023 · 13 comments · Fixed by #767
Closed

Test plan version history page is incomplete #761

mcking65 opened this issue Aug 30, 2023 · 13 comments · Fixed by #767
Assignees
Labels
accessibility bug Something isn't working

Comments

@mcking65
Copy link

On the test plan version page:

  1. Version summary tables are missing versions.
  2. Tables of 'Timeline for All Versions' are missing both events and versions.
  3. GitHub issues are not shown.
  4. Version headings should show most recent versions first.
  5. Some heading levels are incorrect.
  6. Tables are missing captions.
  7. Strings in headings and table cells are run together.

As I go through this page, given the length of sections, I wonder if it would be beneficial for all level 2 headings after the version summary to be disclosures that are collapsed by default, e.g.:

<h2><button aria-expanded="false">GitHub Issues</button></h2>

Then people could easily see what is on the page without scrolling down.

Note that details/summary can't be used for this because you can't wrap a summary in a heading, and the heading navigation is super important.

Here is more information about each of the above problems using Radio Group Example Using aria-activedescendant Test Plan Versions | ARIA-AT as an illustrative example.

Version summary tables are missing versions

The radio version summary table shows data for:

  • V23.04.10
  • V22.05.18

According to the commit history, the following versions are missing:

  • V2023.08.23
  • V2022.12.8
  • V2022.05.5
  • V2022.04.7
  • V2022.03.17
  • V2021.10.13
  • V2021.09.22
  • V2021.07.22

Tables of 'Timeline for All Versions' are missing both events and versions

The radio timeline shows more versions that the summary, but several are still missing. In addition, many events are missing.

Deprecations are not shown. For example, it shows V21.10.13 R&D Complete, but that version never shows a deprecation event, which most likely occurred on march 17, 2022 when R&D was completed for V2022.03.17 (one of the versions missing from the timeline.

Similarly, there is an event for V22.05.18 Draft Review Started, but there is no event in the table for R&D complete of that version.

There is an event for V23.04.10 Candidate Review Started, but that version doesn't have R&D complete or draft review started.

In the timeline tables that are for one specific version, I failed to mention that if two events occur on the same day, the second sort factor should be phase. It is confusing to see draft review started listed in the table before R&D complete because a plan has to complete R&D before it can go to draft review.

GitHub issues are not shown

I couldn't find a plan that lists any GitHub issues. We definitely have issues for several of the plans that should be listed. Is it the case that this feature is still being developed? If so, it would be better to leave out the heading until we have the data pipeline for it. I assumed it was complete because #719 is marked as in the sandbox and we don't have a separate issue tracking this part of #719 nor a reference to one from #719.

Version headings should show most recent versions first

My apologies for showing this requirement only in the mockup and not documenting it in the text of #719. As one navigates by heading through the history, like the version summary table, the most recent plan version sections should be at the top.

Some heading levels are incorrect.

The information architecture of the page is that a version heading should be level 2 and the timeline information for that version is a subsection. This is currently backward. Currently:

V23.04.10Candidateon Apr 9, 2022

is a level 3, but it should be level 2.

The heading:

Timeline for V23.04.10

is currently a level2, but this is a subsection of information for that version so should be level 3.

Tables are missing captions

Issue #719 specifies captions. That is primarily so the tables will have accessible names. If visible captions are redundant due to the presence of the headings, then please use aria-labelledby or aria-label to provide the equivalent accessible label.

Strings in headings and table cells are run together

This is an issue similar to #718. Example of a heading problem:

V22.05.18Drafton May 18, 2022

Note that "Draft" and "on" are run together; they need a space between them.

Similarly in the all versions timeline tables:

V22.05.18Draft Review Started

"V22.05.18" and "Draft" are run together as a single word. They need to be separated with a space, a br or semantically separated into list items.

@howard-e
Copy link
Contributor

As I go through this page, given the length of sections, I wonder if it would be beneficial for all level 2 headings after the version summary to be disclosures that are collapsed by default, e.g.:

<h2><button aria-expanded="false">GitHub Issues</button></h2>

Then people could easily see what is on the page without scrolling down.

Sounds like a good plan.

Note that details/summary can't be used for this because you can't wrap a summary in a heading, and the heading navigation is super important.

Noted, will check it out

Version summary tables are missing versions

The radio version summary table shows data for:

  • V23.04.10
  • V22.05.18

According to the commit history, the following versions are missing:

  • V2023.08.23
  • V2022.12.8
  • V2022.05.5
  • V2022.04.7
  • V2022.03.17
  • V2021.10.13
  • V2021.09.22
  • V2021.07.22

A number of versions could be missing because of how the previous import tests script was being done, but no TestPlanVersions were deleted during the migrations which matched against a known commit. Those commits were simply never properly captured by the system in the past. It's also a part of what #721 will prevent in the future. But what that PR, and this new set of migrations didn't do is attempt to backload that missing version data across all the test plans. Is that the expectation?

Another thing to note is that not all versions may even be included for a test plan, if the test data hash matches up with a previously imported known hash of another version for that test plan. My response here covers why that is: #760 (comment)

Tables of 'Timeline for All Versions' are missing both events and versions

The radio timeline shows more versions that the summary, but several are still missing. In addition, many events are missing.

Deprecations are not shown. For example, it shows V21.10.13 R&D Complete, but that version never shows a deprecation event, which most likely occurred on march 17, 2022 when R&D was completed for V2022.03.17 (one of the versions missing from the timeline.

A migration can be added to set these and other examples to being deprecated. The only known example of this can be seen on the Disclosure Navigation Test Plan Versions page

Similarly, there is an event for V22.05.18 Draft Review Started, but there is no event in the table for R&D complete of that version.

Scrolling down, that event is listed under the Timeline for V22.05.18 table, as R&D Complete on May 18, 2022 along with the Draft phase change

There is an event for V23.04.10 Candidate Review Started, but that version doesn't have R&D complete or draft review started.

Like above, scrolling down, those events are under Timeline for V23.04.10

In the timeline tables that are for one specific version, I failed to mention that if two events occur on the same day, the second sort factor should be phase. It is confusing to see draft review started listed in the table before R&D complete because a plan has to complete R&D before it can go to draft review.

Noted, I made an issue in #763 to discuss before seeing this.

GitHub issues are not shown

I couldn't find a plan that lists any GitHub issues. We definitely have issues for several of the plans that should be listed. Is it the case that this feature is still being developed? If so, it would be better to leave out the heading until we have the data pipeline for it. I assumed it was complete because #719 is marked as in the sandbox and we don't have a separate issue tracking this part of #719 nor a reference to one from #719.

#753 covered this change. I had mentioned during last week's CG meeting that making changes to the existing aria-at 'Feedback:' issues would be required for them to picked up in the app. This would be a change to the title (to include the VYY.MM.DD version string) and adding appropriate labels where needed. Alex most recently tested the creation and viewing of issues through my fork for the sake of that PR. It is still on the Bocoup team to update those issue titles. I'll create an issue to track this.

I mentioned in #759 (comment) that we'll also want to point the sandbox/staging environments to Bocoup's aria-at issues fork to test this feature without creating noise in w3c/aria-at for future pushes.

Version headings should show most recent versions first

My apologies for showing this requirement only in the mockup and not documenting it in the text of #719. As one navigates by heading through the history, like the version summary table, the most recent plan version sections should be at the top.

Okay, noted, this will be addressed.

Some heading levels are incorrect.

The information architecture of the page is that a version heading should be level 2 and the timeline information for that version is a subsection. This is currently backward. Currently:

V23.04.10Candidateon Apr 9, 2022

is a level 3, but it should be level 2.

The heading:

Timeline for V23.04.10

is currently a level2, but this is a subsection of information for that version so should be level 3.

Noted, this will be addressed.

Tables are missing captions

Issue #719 specifies captions. That is primarily so the tables will have accessible names. If visible captions are redundant due to the presence of the headings, then please use aria-labelledby or aria-label to provide the equivalent accessible label.

Will do.

Strings in headings and table cells are run together

This is an issue similar to #718. Example of a heading problem:

V22.05.18Drafton May 18, 2022

Note that "Draft" and "on" are run together; they need a space between them.

Similarly in the all versions timeline tables:

V22.05.18Draft Review Started

"V22.05.18" and "Draft" are run together as a single word. They need to be separated with a space, a br or semantically separated into list items.

Yep, this is certainly similar to what was being experienced on the Data Management page in #718. Will check that out.

@howard-e howard-e self-assigned this Aug 30, 2023
@howard-e howard-e linked a pull request Aug 30, 2023 that will close this issue
@howard-e
Copy link
Contributor

howard-e commented Aug 30, 2023

@mcking65 I've submitted #767 which addresses the following:

  • Version headings should show most recent versions first
  • Some heading levels are incorrect.
  • Tables are missing captions
  • Strings in headings and table cells are run together

As I go through this page, given the length of sections, I wonder if it would be beneficial for all level 2 headings after the version summary to be disclosures that are collapsed by default, e.g.:

<h2><button aria-expanded="false">GitHub Issues</button></h2>

Then people could easily see what is on the page without scrolling down.

Would you be okay with this being included in a separate P1 enhancement issue?

Tables of 'Timeline for All Versions' are missing both events and versions

The note on deprecations is also a separate issue - but can you re-confirm that the events you noted as missing, are in fact missing for you?

GitHub issues are not shown

I've submitted #768 to track this task

@mcking65
Copy link
Author

Version summary tables are missing versions

The radio version summary table shows data for:

  • V23.04.10
  • V22.05.18

According to the commit history, the following versions are missing:

  • V2023.08.23
  • V2022.12.8
  • V2022.05.5
  • V2022.04.7
  • V2022.03.17
  • V2021.10.13
  • V2021.09.22
  • V2021.07.22

A number of versions could be missing because of how the previous import tests script was being done, but no TestPlanVersions were deleted during the migrations which matched against a known commit. Those commits were simply never properly captured by the system in the past. It's also a part of what #721 will prevent in the future. But what that PR, and this new set of migrations didn't do is attempt to backload that missing version data across all the test plans. Is that the expectation?

Yes, please. The version history should be complete.

Another thing to note is that not all versions may even be included for a test plan, if the test data hash matches up with a previously imported known hash of another version for that test plan. My response here covers why that is: #760 (comment)

This is the system being smarter than I realized, which is good. I would like to review what goes into the hashing algorithm. I'll comment in 760.

Tables of 'Timeline for All Versions' are missing both events and versions

The radio timeline shows more versions that the summary, but several are still missing. In addition, many events are missing.
Deprecations are not shown. For example, it shows V21.10.13 R&D Complete, but that version never shows a deprecation event, which most likely occurred on march 17, 2022 when R&D was completed for V2022.03.17 (one of the versions missing from the timeline.

A migration can be added to set these and other examples to being deprecated. The only known example of this can be seen on the Disclosure Navigation Test Plan Versions page

Yes, please make this part of the migration so data is consistent and complete.

Similarly, there is an event for V22.05.18 Draft Review Started, but there is no event in the table for R&D complete of that version.

Scrolling down, that event is listed under the Timeline for V22.05.18 table, as R&D Complete on May 18, 2022 along with the Draft phase change

Yes, it is down there, but the timeline for all versions is to show all events for all versions. Was that requirement unclear? The versions table should list all versions. The timeline for all versions shows every event, in time order, for all the versions. The sections below then make it easy to track what happened with any one version.

There is an event for V23.04.10 Candidate Review Started, but that version doesn't have R&D complete or draft review started.

Like above, scrolling down, those events are under Timeline for V23.04.10

Yes, and they also need to be in the all events table.

In the timeline tables that are for one specific version, I failed to mention that if two events occur on the same day, the second sort factor should be phase. It is confusing to see draft review started listed in the table before R&D complete because a plan has to complete R&D before it can go to draft review.

Noted, I made an issue in #763 to discuss before seeing this.

OK, thanks, will comment in 763.

GitHub issues are not shown

I couldn't find a plan that lists any GitHub issues. We definitely have issues for several of the plans that should be listed. Is it the case that this feature is still being developed? If so, it would be better to leave out the heading until we have the data pipeline for it. I assumed it was complete because #719 is marked as in the sandbox and we don't have a separate issue tracking this part of #719 nor a reference to one from #719.

#753 covered this change. I had mentioned during last week's CG meeting that making changes to the existing aria-at 'Feedback:' issues would be required for them to picked up in the app. This would be a change to the title (to include the VYY.MM.DD version string) and adding appropriate labels where needed. Alex most recently tested the creation and viewing of issues through my fork for the sake of that PR. It is still on the Bocoup team to update those issue titles. I'll create an issue to track this.

As discussed in our meeting, I prefer not to update the titles or have dependency on the titles. I'd like the freedom to edit titles for clarity and brevity when working with vendors. As we work with the vendors, I've wanted the titles to be more descriptive of some of the details in the issues.

Let's please go for labels only, or if necessary, tags in hidden comments. <!-- ... -->. If using hidden comment strings, let's standardize the strings so humans could potentially manipulate them.

I mentioned in #759 (comment) that we'll also want to point the sandbox/staging environments to Bocoup's aria-at issues fork to test this feature without creating noise in w3c/aria-at for future pushes.

Perfect.

Version headings should show most recent versions first

My apologies for showing this requirement only in the mockup and not documenting it in the text of #719. As one navigates by heading through the history, like the version summary table, the most recent plan version sections should be at the top.

Okay, noted, this will be addressed.

Thank you!! Sorry for the churn and lack of specificity on that.

Some heading levels are incorrect.

The information architecture of the page is that a version heading should be level 2 and the timeline information for that version is a subsection. This is currently backward. Currently:

V23.04.10Candidateon Apr 9, 2022

is a level 3, but it should be level 2.
The heading:

Timeline for V23.04.10

is currently a level2, but this is a subsection of information for that version so should be level 3.

Noted, this will be addressed.

Thanks!!

Tables are missing captions

Issue #719 specifies captions. That is primarily so the tables will have accessible names. If visible captions are redundant due to the presence of the headings, then please use aria-labelledby or aria-label to provide the equivalent accessible label.

Will do.

Thanks!!

Strings in headings and table cells are run together

This is an issue similar to #718. Example of a heading problem:

V22.05.18Drafton May 18, 2022

Note that "Draft" and "on" are run together; they need a space between them.
Similarly in the all versions timeline tables:

V22.05.18Draft Review Started

"V22.05.18" and "Draft" are run together as a single word. They need to be separated with a space, a br or semantically separated into list items.

Yep, this is certainly similar to what was being experienced on the Data Management page in #718. Will check that out.

Thanks!!

@mcking65
Copy link
Author

There is something strange happening in the data. Consider the Disclosure Navigation Menu Example Test Plan Versions | ARIA-AT that you referenced above.

It shows the Timeline for V22.10.31 as:

Date Event
Apr 9, 2022 Candidate Review Started
Oct 31, 2022 R&D Complete
Oct 31, 2022 Draft Review Started

Obviously, we can't start candidate review on April 9 for a version that didn't exist until Oct 31. April 9 is the candidate review start for version V21.11.30. It appears that the candidate review start for
V22.10.31 is Aug 29, 2023. So, the timeline table for V22.10.31 should be:

Date Event
Oct 31, 2022 R&D Complete
Oct 31, 2022 Draft Review Started
Aug 29, 2023 Candidate Review Started

@mcking65
Copy link
Author

@mcking65 I've submitted #767 which addresses the following:

  • Version headings should show most recent versions first
  • Some heading levels are incorrect.
  • Tables are missing captions
  • Strings in headings and table cells are run together

Amazing Speed!

As I go through this page, given the length of sections, I wonder if it would be beneficial for all level 2 headings after the version summary to be disclosures that are collapsed by default, e.g.:
<h2><button aria-expanded="false">GitHub Issues</button></h2>
Then people could easily see what is on the page without scrolling down.

Would you be okay with this being included in a separate P1 enhancement issue?

Yes, and it could be a p2.

Tables of 'Timeline for All Versions' are missing both events and versions

The note on deprecations is also a separate issue - but can you re-confirm that the events you noted as missing, are in fact missing for you?

Yes, please see my explanation that the all versions timeline should include all events from all versions.

GitHub issues are not shown

I've submitted #768 to track this task

I'll comment in 768.

@howard-e
Copy link
Contributor

howard-e commented Aug 30, 2023

@mcking65 I've submitted #767 which addresses the following:

  • Version headings should show most recent versions first
  • Some heading levels are incorrect.
  • Tables are missing captions
  • Strings in headings and table cells are run together

Amazing Speed!

#767 which includes those 4 items have been added to the sandbox and staging environments but also acknowledging that there's other items to be checked out here first before this can be considered done.

As I go through this page, given the length of sections, I wonder if it would be beneficial for all level 2 headings after the version summary to be disclosures that are collapsed by default, e.g.:
<h2><button aria-expanded="false">GitHub Issues</button></h2>
Then people could easily see what is on the page without scrolling down.

Would you be okay with this being included in a separate P1 enhancement issue?

Yes, and it could be a p2.

Sounds good! I'll create a separate issue

Tables of 'Timeline for All Versions' are missing both events and versions

The note on deprecations is also a separate issue - but can you re-confirm that the events you noted as missing, are in fact missing for you?

Yes, please see my explanation that the all versions timeline should include all events from all versions.

I'll check this out again

@howard-e
Copy link
Contributor

howard-e commented Aug 30, 2023

There is something strange happening in the data. Consider the Disclosure Navigation Menu Example Test Plan Versions | ARIA-AT that you referenced above.

It shows the Timeline for V22.10.31 as:

Date Event
Apr 9, 2022 Candidate Review Started
Oct 31, 2022 R&D Complete
Oct 31, 2022 Draft Review Started
Obviously, we can't start candidate review on April 9 for a version that didn't exist until Oct 31. April 9 is the candidate review start for version V21.11.30. It appears that the candidate review start for V22.10.31 is Aug 29, 2023. So, the timeline table for V22.10.31 should be:

Date Event
Oct 31, 2022 R&D Complete
Oct 31, 2022 Draft Review Started
Aug 29, 2023 Candidate Review Started

There's certainly a few of these reported date transitions across the CANDIDATE test plan versions not being possible, after this series of migrations combined so much data. Will check out adding a supporting migration to have more practical dates here and align with what you've described.

@howard-e
Copy link
Contributor

howard-e commented Sep 5, 2023

Tables of 'Timeline for All Versions' are missing both events and versions

Missing TestPlanVersions data

Version summary tables are missing versions

The radio version summary table shows data for:

  • V23.04.10
  • V22.05.18

According to the commit history, the following versions are missing:

  • V2023.08.23
  • V2022.12.8
  • V2022.05.5
  • V2022.04.7
  • V2022.03.17
  • V2021.10.13
  • V2021.09.22
  • V2021.07.22

A number of versions could be missing because of how the previous import tests script was being done, but no TestPlanVersions were deleted during the migrations which matched against a known commit. Those commits were simply never properly captured by the system in the past. It's also a part of what #721 will prevent in the future. But what that PR, and this new set of migrations didn't do is attempt to backload that missing version data across all the test plans. Is that the expectation?

@mcking65 said: Yes, please. The version history should be complete.

@mcking65 this can be a follow-up action. This isn't a code change and will require running a script in the production environment to capture the missing data (and will take a significant amount of time to run). I'll validate beforehand on the sandbox environment before performing on the production side, but I don't think this particular action should have to hold up changes, as the data is current. Additionally, loading in some of the older versions may not be properly supported as the structure would have been significantly different back then, so it may a much more detailed process than we think right now.

Here's a count of the missing versions for each directory (the amount which should ACTUALLY be included, considering https://github.com//issues/760#issuecomment-1699139212, I'm unsure about right now)
  • alert: 4
  • banner: 2
  • breadcrumb: 2
  • checkbox: 29
  • checkbox-tri-state: 6
  • combobox-autocomplete-both-updated: 5
  • combobox-select-only: 6
  • command-button: 4
  • complementary: 1
  • contentinfo: 1
  • datepicker-spin-button: 1
  • disclosure-faq: 2
  • disclosure-navigation: 3
  • form: 1
  • horizontal-slider: 2
  • link-css: 1
  • link-img-alt: 1
  • link-span-text: 2
  • main: 2
  • menu-button-actions: 2
  • menu-button-actions-active-descendant: 5
  • menu-button-navigation: 1
  • menubar-editor: 29
  • meter: 2
  • minimal-data-grid: 4
  • modal-dialog: 8
  • radiogroup-aria-activedescendant: 5
  • radiogroup-roving-tabindex: 4
  • rating-slider: 2
  • seek-slider: 1
  • slider-multithumb: 1
  • switch: 2
  • tabs-manual-activation: 7
  • toggle-button: 5
  • vertical-temperature-slider: 2
And detailed info on exactly which is missing for each directory
{
  "alert": [
    {
      "sha": "836fb2a997f5b2844035b8c934f8fda9833cd5b2",
      "commitDate": "2023-08-23T20:30:34Z"
    },
    {
      "sha": "c665367f3742c2b607f7b3c2655782188b93f302",
      "commitDate": "2022-04-14T17:59:42Z"
    },
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    },
    {
      "sha": "d64123608778bbe0b2f1ff86e67c65a5bb4f26ac",
      "commitDate": "2021-10-15T19:44:12Z"
    }
  ],
  "banner": [
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    },
    {
      "sha": "e93f1f542561c652dd9bcebdd8b123c1f2d3332a",
      "commitDate": "2022-01-04T23:43:41Z"
    }
  ],
  "breadcrumb": [
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    },
    {
      "sha": "c1f1d6e6cada2371d56c0ade29db1e46632b56bb",
      "commitDate": "2021-10-15T21:11:27Z"
    }
  ],
  "checkbox": [
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    },
    {
      "sha": "c2df595d0581cf832122456ad3b6944d3152d225",
      "commitDate": "2021-09-20T17:53:40Z"
    },
    {
      "sha": "693acebd0fb0a1bea86f8394648c957a306a4749",
      "commitDate": "2021-06-29T21:13:31Z"
    },
    {
      "sha": "4ca7842ea7777b668546e74c9b5ed5b09696d927",
      "commitDate": "2021-06-15T17:41:07Z"
    },
    {
      "sha": "01c265601d2e125851671c2a1f2c3b2d83a40bfb",
      "commitDate": "2021-06-14T19:04:02Z"
    },
    {
      "sha": "439895407076c3fde767cdd7751d0195b870931b",
      "commitDate": "2020-12-03T00:02:40Z"
    },
    {
      "sha": "4d77ba271c1caf15792252e560ff47a6b7fd4d05",
      "commitDate": "2020-12-02T22:26:26Z"
    },
    {
      "sha": "24efd4889dd3373417d25c069acecfec75c7bd9d",
      "commitDate": "2020-12-01T17:07:09Z"
    },
    {
      "sha": "852a6fd4e1e3c9795e8438afb6c5495e2aca79c3",
      "commitDate": "2020-09-11T01:21:49Z"
    },
    {
      "sha": "746f469c258cf3412fa3fb19f427666c5acd1476",
      "commitDate": "2020-10-27T17:43:44Z"
    },
    {
      "sha": "4d24c9b36563c832c75f48a999a5747fa2265462",
      "commitDate": "2020-08-12T19:10:39Z"
    },
    {
      "sha": "196295c92da967ea625105c7ea7e94b962e7cbf1",
      "commitDate": "2020-05-27T16:43:42Z"
    },
    {
      "sha": "0a88a6ceae079db866c561fbac26576519cca2f9",
      "commitDate": "2020-05-14T00:00:23Z"
    },
    {
      "sha": "ff1ed8a347dfc5ca7be47fa8620cfac681af0439",
      "commitDate": "2020-05-06T19:55:54Z"
    },
    {
      "sha": "f5cf1093789faa6bd3f288168a4440fdeb057766",
      "commitDate": "2020-04-22T11:22:12Z"
    },
    {
      "sha": "350b253c20c7c60599781d03b8364458888b33df",
      "commitDate": "2020-04-15T19:16:53Z"
    },
    {
      "sha": "6ea114f3f9e6fab0b42b79f8336a733a6b546a40",
      "commitDate": "2020-02-28T14:09:59Z"
    },
    {
      "sha": "8c5cd1b910a1285c55ab5268c3b811df5a6116ae",
      "commitDate": "2020-02-28T14:07:44Z"
    },
    {
      "sha": "e8cf7307910c829112369730ab0dd446b433a68a",
      "commitDate": "2020-02-26T21:27:04Z"
    },
    {
      "sha": "4da94cb82b63b4202c6b46ca91fc71e0cae2f540",
      "commitDate": "2020-02-25T14:23:58Z"
    },
    {
      "sha": "2d6757ad59a8907765e686783e5bac8a06bcbccb",
      "commitDate": "2020-02-25T14:09:14Z"
    },
    {
      "sha": "cf786e9a84cc8b892cf8fae15e6c83d897bf57e1",
      "commitDate": "2020-02-25T13:49:58Z"
    },
    {
      "sha": "61678c73c51271068dcff1c30276a1b50c56ace9",
      "commitDate": "2020-02-25T13:48:22Z"
    },
    {
      "sha": "ef543251c0c66c303c7806ac3fdbcd2da3b05364",
      "commitDate": "2020-02-24T22:35:45Z"
    },
    {
      "sha": "0174f2293a68ef45f4f1858d03dd7660d138ebff",
      "commitDate": "2020-02-21T23:26:19Z"
    },
    {
      "sha": "f9db560804f95b3ad76b24e2706207ae2c126388",
      "commitDate": "2020-02-19T22:12:46Z"
    },
    {
      "sha": "da2d989d867255c8f2c02abe3cdbd545f89d0c3e",
      "commitDate": "2020-02-19T22:08:53Z"
    },
    {
      "sha": "e0124a59ef0f557b9b9524cf562aab5f8e2f5953",
      "commitDate": "2020-02-12T18:37:55Z"
    },
    {
      "sha": "a1026c39ab4e9129b40d358b8f7e11637c3bb2d7",
      "commitDate": "2020-02-14T02:20:51Z"
    }
  ],
  "checkbox-tri-state": [
    {
      "sha": "836fb2a997f5b2844035b8c934f8fda9833cd5b2",
      "commitDate": "2023-08-23T20:30:34Z"
    },
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    },
    {
      "sha": "693acebd0fb0a1bea86f8394648c957a306a4749",
      "commitDate": "2021-06-29T21:13:31Z"
    },
    {
      "sha": "4ca7842ea7777b668546e74c9b5ed5b09696d927",
      "commitDate": "2021-06-15T17:41:07Z"
    },
    {
      "sha": "01c265601d2e125851671c2a1f2c3b2d83a40bfb",
      "commitDate": "2021-06-14T19:04:02Z"
    },
    {
      "sha": "e7212c4e5c96497cc8a2682e07ee2decd19d3f85",
      "commitDate": "2021-03-25T06:34:12Z"
    }
  ],
  "combobox-autocomplete-both-updated": [
    {
      "sha": "6b2cbcbdbd5f6867cd3c9e96362817c353335187",
      "commitDate": "2022-03-29T16:02:56Z"
    },
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    },
    {
      "sha": "f9dbdf683537aa3817d261dee86db98e98f90cf7",
      "commitDate": "2022-03-09T21:30:19Z"
    },
    {
      "sha": "05c4cf595dcb530bbab3773e440a771afb79b052",
      "commitDate": "2021-09-22T17:55:01Z"
    },
    {
      "sha": "021ff5d582f63335890ef9558e5ea8c6177346cc",
      "commitDate": "2021-07-22T18:28:21Z"
    }
  ],
  "combobox-select-only": [
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    },
    {
      "sha": "f9dbdf683537aa3817d261dee86db98e98f90cf7",
      "commitDate": "2022-03-09T21:30:19Z"
    },
    {
      "sha": "693acebd0fb0a1bea86f8394648c957a306a4749",
      "commitDate": "2021-06-29T21:13:31Z"
    },
    {
      "sha": "4ca7842ea7777b668546e74c9b5ed5b09696d927",
      "commitDate": "2021-06-15T17:41:07Z"
    },
    {
      "sha": "01c265601d2e125851671c2a1f2c3b2d83a40bfb",
      "commitDate": "2021-06-14T19:04:02Z"
    },
    {
      "sha": "9198d4a8080985a92a100a25e4710fd82104bf1c",
      "commitDate": "2021-03-25T06:20:53Z"
    }
  ],
  "command-button": [
    {
      "sha": "836fb2a997f5b2844035b8c934f8fda9833cd5b2",
      "commitDate": "2023-08-23T20:30:34Z"
    },
    {
      "sha": "dd216174a995f0563f7534d6f90fe813f53c3e80",
      "commitDate": "2022-04-08T19:44:07Z"
    },
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    },
    {
      "sha": "309db24a6b428ce910dc0f8807cbfa1749fd2883",
      "commitDate": "2021-07-22T18:48:58Z"
    }
  ],
  "complementary": [
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    }
  ],
  "contentinfo": [
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    }
  ],
  "datepicker-spin-button": [
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    }
  ],
  "disclosure-faq": [
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    },
    {
      "sha": "b2f05a4eea169f0628422cb6d7fdff37e5b3a2c4",
      "commitDate": "2021-07-20T18:33:03Z"
    }
  ],
  "disclosure-navigation": [
    {
      "sha": "836fb2a997f5b2844035b8c934f8fda9833cd5b2",
      "commitDate": "2023-08-23T20:30:34Z"
    },
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    },
    {
      "sha": "9eb5898dd93d5a352caa9764b7824c279f0163f1",
      "commitDate": "2021-07-20T18:15:03Z"
    }
  ],
  "form": [
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    }
  ],
  "horizontal-slider": [
    {
      "sha": "836fb2a997f5b2844035b8c934f8fda9833cd5b2",
      "commitDate": "2023-08-23T20:30:34Z"
    },
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    }
  ],
  "link-css": [
    {
      "sha": "836fb2a997f5b2844035b8c934f8fda9833cd5b2",
      "commitDate": "2023-08-23T20:30:34Z"
    }
  ],
  "link-img-alt": [
    {
      "sha": "836fb2a997f5b2844035b8c934f8fda9833cd5b2",
      "commitDate": "2023-08-23T20:30:34Z"
    }
  ],
  "link-span-text": [
    {
      "sha": "836fb2a997f5b2844035b8c934f8fda9833cd5b2",
      "commitDate": "2023-08-23T20:30:34Z"
    },
    {
      "sha": "c16567f98e99c5b78a73251a925fe71f26382a35",
      "commitDate": "2022-04-14T17:58:34Z"
    }
  ],
  "main": [
    {
      "sha": "836fb2a997f5b2844035b8c934f8fda9833cd5b2",
      "commitDate": "2023-08-23T20:30:34Z"
    },
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    }
  ],
  "menu-button-actions": [
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    },
    {
      "sha": "40743548680a3938a8f39fe54baa1b027a5434c2",
      "commitDate": "2021-07-22T18:35:04Z"
    }
  ],
  "menu-button-actions-active-descendant": [
    {
      "sha": "836fb2a997f5b2844035b8c934f8fda9833cd5b2",
      "commitDate": "2023-08-23T20:30:34Z"
    },
    {
      "sha": "693acebd0fb0a1bea86f8394648c957a306a4749",
      "commitDate": "2021-06-29T21:13:31Z"
    },
    {
      "sha": "4ca7842ea7777b668546e74c9b5ed5b09696d927",
      "commitDate": "2021-06-15T17:41:07Z"
    },
    {
      "sha": "01c265601d2e125851671c2a1f2c3b2d83a40bfb",
      "commitDate": "2021-06-14T19:04:02Z"
    },
    {
      "sha": "9646312951b9be490c45adb45e1bc53e7712c989",
      "commitDate": "2021-03-11T19:05:16Z"
    }
  ],
  "menu-button-navigation": [
    {
      "sha": "836fb2a997f5b2844035b8c934f8fda9833cd5b2",
      "commitDate": "2023-08-23T20:30:34Z"
    }
  ],
  "menubar-editor": [
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    },
    {
      "sha": "05c4cf595dcb530bbab3773e440a771afb79b052",
      "commitDate": "2021-09-22T17:55:01Z"
    },
    {
      "sha": "c2df595d0581cf832122456ad3b6944d3152d225",
      "commitDate": "2021-09-20T17:53:40Z"
    },
    {
      "sha": "693acebd0fb0a1bea86f8394648c957a306a4749",
      "commitDate": "2021-06-29T21:13:31Z"
    },
    {
      "sha": "4ca7842ea7777b668546e74c9b5ed5b09696d927",
      "commitDate": "2021-06-15T17:41:07Z"
    },
    {
      "sha": "01c265601d2e125851671c2a1f2c3b2d83a40bfb",
      "commitDate": "2021-06-14T19:04:02Z"
    },
    {
      "sha": "439895407076c3fde767cdd7751d0195b870931b",
      "commitDate": "2020-12-03T00:02:40Z"
    },
    {
      "sha": "4d77ba271c1caf15792252e560ff47a6b7fd4d05",
      "commitDate": "2020-12-02T22:26:26Z"
    },
    {
      "sha": "24efd4889dd3373417d25c069acecfec75c7bd9d",
      "commitDate": "2020-12-01T17:07:09Z"
    },
    {
      "sha": "852a6fd4e1e3c9795e8438afb6c5495e2aca79c3",
      "commitDate": "2020-09-11T01:21:49Z"
    },
    {
      "sha": "746f469c258cf3412fa3fb19f427666c5acd1476",
      "commitDate": "2020-10-27T17:43:44Z"
    },
    {
      "sha": "826d2c2a6a9c5b9c7045d6fa7e1b575ce4fb9762",
      "commitDate": "2020-07-29T19:52:57Z"
    },
    {
      "sha": "869b61f55fb4968190d07648f9f9bca43116eff9",
      "commitDate": "2020-05-27T17:05:13Z"
    },
    {
      "sha": "6497c20dc2f16768c62e6b646602fcde9076c1e0",
      "commitDate": "2020-05-26T21:56:15Z"
    },
    {
      "sha": "38a5339542f9bfe4d72b816bbbfb178d347ddb9e",
      "commitDate": "2020-05-26T21:40:59Z"
    },
    {
      "sha": "29edd58a2e55d8bd318750d43cae1b0474fe1d75",
      "commitDate": "2020-05-25T02:04:54Z"
    },
    {
      "sha": "0a88a6ceae079db866c561fbac26576519cca2f9",
      "commitDate": "2020-05-14T00:00:23Z"
    },
    {
      "sha": "be4a5297e167ac879f4909051b6a10446e25d853",
      "commitDate": "2020-04-22T19:48:41Z"
    },
    {
      "sha": "f5cf1093789faa6bd3f288168a4440fdeb057766",
      "commitDate": "2020-04-22T11:22:12Z"
    },
    {
      "sha": "e7a754db38716910812a3e51ff048ec3d7385938",
      "commitDate": "2020-04-21T21:39:23Z"
    },
    {
      "sha": "e6c5c69d75bed1af607e4d602d198c322b7185e7",
      "commitDate": "2020-04-21T20:33:12Z"
    },
    {
      "sha": "123adabb9f1f37cfbdaa24f46b4f0b9ff6cb2bf4",
      "commitDate": "2020-04-17T18:26:14Z"
    },
    {
      "sha": "350b253c20c7c60599781d03b8364458888b33df",
      "commitDate": "2020-04-15T19:16:53Z"
    },
    {
      "sha": "16631dfb4301e9e530900c76b664e9535dda5de9",
      "commitDate": "2020-04-08T12:20:25Z"
    },
    {
      "sha": "d187d4843be732b9263ab31a8916a2f25852ef8e",
      "commitDate": "2020-04-01T19:43:22Z"
    },
    {
      "sha": "6d6a5669b9cffd73e766c5fb7ef321362aba8c52",
      "commitDate": "2020-03-09T15:38:54Z"
    },
    {
      "sha": "3df520a5a148f08c3d1607bb9572c66c88a28bc2",
      "commitDate": "2020-03-08T18:44:13Z"
    },
    {
      "sha": "d4d5bd25100764a66d7cf1f55cfc4ac9580c02e9",
      "commitDate": "2020-03-06T22:16:44Z"
    },
    {
      "sha": "2315863dee6d622d0806614f47fdef8d2caeecbe",
      "commitDate": "2020-03-06T22:05:46Z"
    }
  ],
  "meter": [
    {
      "sha": "836fb2a997f5b2844035b8c934f8fda9833cd5b2",
      "commitDate": "2023-08-23T20:30:34Z"
    },
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    }
  ],
  "minimal-data-grid": [
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    },
    {
      "sha": "f9dbdf683537aa3817d261dee86db98e98f90cf7",
      "commitDate": "2022-03-09T21:30:19Z"
    },
    {
      "sha": "05c4cf595dcb530bbab3773e440a771afb79b052",
      "commitDate": "2021-09-22T17:55:01Z"
    },
    {
      "sha": "3f475605575c86b5d55221c5a496f0d24b85333a",
      "commitDate": "2021-07-22T18:06:23Z"
    }
  ],
  "modal-dialog": [
    {
      "sha": "836fb2a997f5b2844035b8c934f8fda9833cd5b2",
      "commitDate": "2023-08-23T20:30:34Z"
    },
    {
      "sha": "5fe7afd82fe51c185b8661276105190a59d47322",
      "commitDate": "2022-05-26T16:10:10Z"
    },
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    },
    {
      "sha": "091420a186f267d6ed8f581dc0e8e168d194e709",
      "commitDate": "2021-10-13T15:20:58Z"
    },
    {
      "sha": "693acebd0fb0a1bea86f8394648c957a306a4749",
      "commitDate": "2021-06-29T21:13:31Z"
    },
    {
      "sha": "4ca7842ea7777b668546e74c9b5ed5b09696d927",
      "commitDate": "2021-06-15T17:41:07Z"
    },
    {
      "sha": "01c265601d2e125851671c2a1f2c3b2d83a40bfb",
      "commitDate": "2021-06-14T19:04:02Z"
    },
    {
      "sha": "bdaa2ae26464cb1f63b9b7e056ad4b9200dfa482",
      "commitDate": "2021-01-28T00:03:13Z"
    }
  ],
  "radiogroup-aria-activedescendant": [
    {
      "sha": "836fb2a997f5b2844035b8c934f8fda9833cd5b2",
      "commitDate": "2023-08-23T20:30:34Z"
    },
    {
      "sha": "62ed9870a49c9b91f18fc281f7e426f88dd971ac",
      "commitDate": "2022-04-07T22:24:48Z"
    },
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    },
    {
      "sha": "05c4cf595dcb530bbab3773e440a771afb79b052",
      "commitDate": "2021-09-22T17:55:01Z"
    },
    {
      "sha": "f907e09b6d97465bbf2f3f9347540e09aa2bbf7c",
      "commitDate": "2021-07-22T18:45:52Z"
    }
  ],
  "radiogroup-roving-tabindex": [
    {
      "sha": "836fb2a997f5b2844035b8c934f8fda9833cd5b2",
      "commitDate": "2023-08-23T20:30:34Z"
    },
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    },
    {
      "sha": "05c4cf595dcb530bbab3773e440a771afb79b052",
      "commitDate": "2021-09-22T17:55:01Z"
    },
    {
      "sha": "45e473801484239a5653d0e0f63c6d4392a966eb",
      "commitDate": "2021-07-22T18:40:22Z"
    }
  ],
  "rating-slider": [
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    },
    {
      "sha": "b5c67acec2f2e6c858935b1726e28020acb45274",
      "commitDate": "2021-11-04T22:42:05Z"
    }
  ],
  "seek-slider": [
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    }
  ],
  "slider-multithumb": [
    {
      "sha": "836fb2a997f5b2844035b8c934f8fda9833cd5b2",
      "commitDate": "2023-08-23T20:30:34Z"
    }
  ],
  "switch": [
    {
      "sha": "836fb2a997f5b2844035b8c934f8fda9833cd5b2",
      "commitDate": "2023-08-23T20:30:34Z"
    },
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    }
  ],
  "tabs-manual-activation": [
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    },
    {
      "sha": "05c4cf595dcb530bbab3773e440a771afb79b052",
      "commitDate": "2021-09-22T17:55:01Z"
    },
    {
      "sha": "9ae52a34e4ec03a2472fbbb1819ecdff2b2066ee",
      "commitDate": "2021-09-07T17:34:58Z"
    },
    {
      "sha": "693acebd0fb0a1bea86f8394648c957a306a4749",
      "commitDate": "2021-06-29T21:13:31Z"
    },
    {
      "sha": "4ca7842ea7777b668546e74c9b5ed5b09696d927",
      "commitDate": "2021-06-15T17:41:07Z"
    },
    {
      "sha": "01c265601d2e125851671c2a1f2c3b2d83a40bfb",
      "commitDate": "2021-06-14T19:04:02Z"
    },
    {
      "sha": "901b3507e179cbdf2d26fce38a73581ca7908b1e",
      "commitDate": "2021-03-08T05:36:55Z"
    }
  ],
  "toggle-button": [
    {
      "sha": "836fb2a997f5b2844035b8c934f8fda9833cd5b2",
      "commitDate": "2023-08-23T20:30:34Z"
    },
    {
      "sha": "9904e0e67d156d433ab3cc0a96d6e805e94f22e1",
      "commitDate": "2022-04-08T19:51:30Z"
    },
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    },
    {
      "sha": "acc6cb130ab5a6cbf23cbb70c76e7fffd876734f",
      "commitDate": "2021-10-20T18:32:55Z"
    },
    {
      "sha": "f2d5123c3e2e56e443754a0bd09a261649fc6ca4",
      "commitDate": "2021-07-22T18:54:13Z"
    }
  ],
  "vertical-temperature-slider": [
    {
      "sha": "7c4b5dce23c74fcf280ed164bdb903e02e0e7726",
      "commitDate": "2022-03-17T18:34:51Z"
    },
    {
      "sha": "b5c67acec2f2e6c858935b1726e28020acb45274",
      "commitDate": "2021-11-04T22:42:05Z"
    }
  ]
}

Unexpected timeline transitions and missing events

Tables of 'Timeline for All Versions' are missing both events and versions

The note on deprecations is also a separate issue - but can you re-confirm that the events you noted as missing, are in fact missing for you?

Yes, please see my explanation that the all versions timeline should include all events from all versions.

I'll check this out again

Apologies, I follow what you meant after a re-read and this should now be addressed. It also addresses what you described in #761 (comment).

What the migration does is to check older instances of the latest known TestPlanVersions and automatically deprecate them. It also looks for these odd instances of candidate phase being reached before the draft phase or RD, etc (caused by the previous migrations) and sets that to the draftPhaseReachedAtDate + 1 day. Additionally, if a version is in RD when a newer one comes in, it will be automatically deprecated as well. This is a part of #767 and is currently deployed to the testing environments.

GitHub issues are not shown

Will follow up in #768 but we should consider this as also having follow up actions. This is a part of #767 and is currently deployed to the testing environments.

@mcking65
Copy link
Author

@howard-e

The "Timeline for All Versions" is still not showing all the events from all versions on any of the test plans I have looked at.

Basically, The number of rows in the timeline for all versions should be the sum of all rows in all the timeline tables further down the page. That is not the case for any of the test plans.

The timeline for all versions should show all events from all versions. The timeline for each individual version should show all events for that specific version. Thus, the number of rows in timeline for all versions should be the sum of all rows from the other timeline tables.

@mcking65
Copy link
Author

I have one more request for accessibility improvement on this page. It would make the tables more screen reader friendly if we used th instead of td in the version column of the version summary and the date column of the timeline tables.

@howard-e
Copy link
Contributor

The timeline for all versions should show all events from all versions. The timeline for each individual version should show all events for that specific version. Thus, the number of rows in timeline for all versions should be the sum of all rows from the other timeline tables.

I have one more request for accessibility improvement on this page. It would make the tables more screen reader friendly if we used th instead of td in the version column of the version summary and the date column of the timeline tables.

@mcking65 #773 has been submitted to address these and the change has also been pushed to the testing environments.

@mcking65
Copy link
Author

Yay! Everything addressed here! @howard-e, thank you so much for your patient persistance with this issue.

@ccanash
Copy link
Contributor

ccanash commented Oct 3, 2023

Released

@ccanash ccanash closed this as completed Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

3 participants