Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include the latest w3c/aria-at data imports in tests and update sample data #1111

Merged
merged 6 commits into from
May 29, 2024
Merged

Include the latest w3c/aria-at data imports in tests and update sample data #1111

merged 6 commits into from
May 29, 2024

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented May 23, 2024 •
edited
Loading

Address #1107 by doing the following:

  1. Allowing the most recent commits from w3c/aria-at to be imported when importing data from w3c/aria-at again.
  2. This also updates the sample data population script to include a modal-dialog example to test tests which has decimal value presentationNumbers.

Also took the opportunity in this PR to make the yarn db-import-tests:* process multiple commits at once, with -c "commit_1 commit_2". This saves ~30s for me.

@howard-e howard-e changed the title WIP: Support latest imports in tests Include the latest w3c/aria-at data imports in tests and update sample data May 28, 2024
@howard-e howard-e requested a review from gnarf May 28, 2024 20:30
@howard-e howard-e marked this pull request as ready for review May 28, 2024 20:30
@howard-e
Copy link
Contributor Author

howard-e commented May 28, 2024 •
edited
Loading

@gnarf TestPlanVersion 160 and TestPlanReport 19 should have the data you intend to test for in #1106.

gnarf
gnarf approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@gnarf gnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@gnarf gnarf merged commit ae90bce into development May 29, 2024
2 checks passed
@gnarf gnarf deleted the support-latest-imports-in-tests branch May 29, 2024 05:05
@howard-e howard-e mentioned this pull request Jun 12, 2024
Merged
howard-e added a commit that referenced this pull request Jun 12, 2024
@howard-e
Merge pull request #1129 from w3c/development
b1079ce 
June 12, 2024 Release

Issues addressed:
* #1111, addresses #1107
* #1114, addresses #1106
* #1112, addresses #966
* #1127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnarf gnarf gnarf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@howard-e @gnarf