Skip executing fetch handlers if it is no-op. #1674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous flag name has negation in the flag name and I am afraid it is confusing. Let me rename it.
Since [=all fetch listeners are empty flag=] is used only if [=set of event types to handle=] contains "fetch". This actually does not change the behavior.
|
Some of the link-defaults were disguising bikeshed errors, making it ambiguous which terms from other specs need exporting. I've fixed those up, and will PR to the DOM spec to get those terms exported. |
|
PR to export the terms whatwg/dom#1170. However, this includes a term that's marked as "intentionally not exported", so we might need to find another way. |
annevk
pushed a commit
to whatwg/dom
that referenced
this pull request
Mar 22, 2023
annevk
pushed a commit
to whatwg/dom
that referenced
this pull request
Mar 22, 2023
|
Merging. Thanks for all the work on this @yoshisatoyanagisawa! |
github-actions bot
added a commit
that referenced
this pull request
Mar 22, 2023
SHA: 4b38437 Reason: push, by jakearchibald Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to asleekgeek/ServiceWorker
that referenced
this pull request
Mar 22, 2023
SHA: 4b38437 Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #1672
Preview | Diff