Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usages of module fetching html algorithms #1658

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Oct 3, 2022

This updates this spec for whatwg/html#8264 and whatwg/html#8328.


Preview | Diff

@w3cbot
Copy link

w3cbot commented Oct 3, 2022

Ms2ger marked as non substantive for IPR from ash-nazg.

Copy link
Contributor

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Although I don't have merge rights, I hope the editors can merge this soon.

They should delay until ~24 hours from now to make sure the HTML exported definitions get indexed.

@triple-underscore
Copy link

I checked the diff and found that there is one instance of "Asynchronously complete these steps" (in the clause "If maxScopeString is null or scopeString does not start with maxScopeString, then:") which is not replaced with "Invoke processCustomFetchResponse".

@nicolo-ribaudo
Copy link
Member Author

Thanks @triple-underscore, updated!

@nicolo-ribaudo
Copy link
Member Author

Please don't merge this yet, until whatwg/html#8412 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants