Constructable Stylesheets#50
Conversation
thescientist13
changed the title
| </ul> | ||
| <p>From their standards position tracker, Safari has highlighted some of the following concerns:</p> | ||
| <ul> | ||
| <li>Issues related to <a href="https://github.com/WICG/construct-stylesheets/issues/45" target="_blank">race conditions</a> with adopting stylesheets and if the adoptedStyleSheets array should be directly mutable or not</li> |
There was a problem hiding this comment.
I thought this one had been worked out... 🫠
There was a problem hiding this comment.
Yeah. I could have read it wrong or maybe a resolution wasn't communicated? So feel free keep me honest here but those were the breadcrumbs I followed from the Safari positions repo. 👀
Co-authored-by: Westbrook Johnson <westbrook.johnson@gmail.com>
|
Here's the link to what Chromium is using as their IDL for adoptedStyleSeets: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/dom/document_or_shadow_root.idl;l=28. Under the hood, the ObservableArray is implemented as a V8ObservableArrayCSSStyleSheet. I haven't looked into the Firefox implementation. I do know that the property is settable in both Chromium and FF today, which is represented in the IDL linked above. I don't know if that was fully agreed upon though. |
Westbrook
left a comment
Westbrook
left a comment
There was a problem hiding this comment.
LGTM! You mentioned wanting to add one thing in today's meeting, so I'll leave this open in case you want to do that here. If not, merge away!
|
Ah yeah, I think that might have been related to DSD, so will put up another PR for that. |
SHA: 015934f Reason: push, by @thescientist13 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 015934f Reason: push, by @thescientist13 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
3 participants
Initial draft for constructable stylesheets.
I think I did a relatively good job tracking down links and breadcrumbs, but not sure if summarization is thorough enough, so definitely please let me know if I am missing anything critical.