fix(agents): restore controllable background sessions by w0wl0lxd · Pull Request #21 · w0wl0lxd/n00n

w0wl0lxd · 2026-07-20T10:41:42Z

Summary

keep task, almas, and the new agent_control tool available together
open task/ALMAS subagent chats by clicking their tool cards
remove the permanent status-bar thinking... indicator; reasoning remains in expandable chat disclosures
remove the misleading partial HALO prompt-refinement implementation
fix task async completion so long subagents do not fail with handler returned nil without calling ctx:finish()
add background=true to task and ALMAS, returning an agent_id
add agent_control actions to list, inspect, steer, and stop background agents

Verification

nix develop -c cargo nextest run -p n00n-lua -p n00n-ui -p n00n-config — 1961 passed
nix develop -c cargo clippy -p n00n-lua -p n00n-ui -p n00n-config --all-targets -- -D warnings
nix develop -c just gen-docs
built-in tool smoke test confirms agent_control, almas, and task coexist

Signed-off-by: w0wl0lxd <w0wl0lxd@tuta.com>

coderabbitai · 2026-07-20T10:42:01Z

Warning

Review limit reached

@w0wl0lxd, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 49 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3d7c9487-bd55-4abc-a57b-f283723db745

📥 Commits

Reviewing files that changed from the base of the PR and between cedd72a and 60479d6.

📒 Files selected for processing (5)

n00n-lua/src/api/session.rs
n00n-lua/src/api/util/command.rs
n00n-ui/src/event_loop.rs
plugins/agent_control/init.lua
site/docs/content/lua-api/_index.md

📝 Walkthrough

Walkthrough

The pull request replaces the ALMAS plugin surface with Team, adds background-agent control and session cancellation, refactors task execution, updates Team orchestration, expands agent-focused UI behavior, and refreshes related tests and documentation.

Changes

Team and agent orchestration

Layer / File(s)	Summary
Plugin surface and Team rename `AGENTS.md`, `n00n-config/...`, `n00n-lua/src/loader.rs`, `plugins/team/`, `site/docs/content/tools/`	Built-in registration, commands, storage paths, launchers, tests, scripts, and documentation now use Team; `agent_control` is bundled.
Session cancellation API `n00n-lua/src/api/session.rs`, `n00n-lua/src/api/util/command.rs`, `n00n-ui/src/event_loop.rs`	Adds `n00n.session.cancel(id)`, forwards `SessionRequest::Cancel`, validates live sessions, and cancels the current run.
Background task and agent control `plugins/task/init.lua`, `plugins/agent_control/init.lua`, `n00n-lua/tests/task_policy.rs`	Adds background task sessions, task timeouts, synchronous lifecycle handling, and agent list/status/message/stop actions.
Team planning and execution `plugins/team/ibn.lua`, `plugins/team/init.lua`	Adds tier-based fan-out decisions, bounded plans, failure-aware execution, background launching, and swarm limits.
Agent picker and cancellation UI `n00n-ui/src/app/`, `n00n-ui/src/chat.rs`, `n00n-ui/src/components/`	Adds tool-session lookup, agent labels and usage details, cancellation delegation, and updated status rendering.

Estimated code review effort: 4 (Complex) | ~60 minutes

Possibly related PRs

w0wl0lxd/n00n#12: Deletes the ALMAS refinement module and changes built-in plugin naming.
w0wl0lxd/n00n#20: Also changes plugins/task/init.lua task execution and completion behavior.

Poem

A rabbit hops where Team tools bloom,
Background agents dash from the room.
“Stop!” says the carrot, “cancel with care,”
Plans share their results through the air.
ALMAS shed its old costume bright—
Team now guides the moonlit night.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 55.17% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title matches the main change: restoring controllable background sessions for agents.
Description check	✅ Passed	The description is clearly related to the changeset and summarizes the new background-session and agent-control behavior.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/task-almas-preview

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

gemini-code-assist

Code Review

This pull request introduces background agent control capabilities, including a new agent_control plugin to list, inspect, steer, or stop background agents started by task or ALMAS. It also implements a cancel function in the Lua API and UI event loop to cancel the current turn of a live session, allows users to switch active chats by clicking on tool segments in the UI, and removes the adaptive prompt refinement (refine.lua) from ALMAS. Reviewer feedback suggests allowing cancellation of sessions in states other than Working (such as NeedsInput) by checking that the session is not Idle, and using a dynamic forwarded table pattern in the task plugin's background handler to improve maintainability.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Signed-off-by: w0wl0lxd <w0wl0lxd@tuta.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 64b4d4b5dd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: w0wl0lxd <w0wl0lxd@tuta.com>

fix(agents): harden tasks and agent teams

Signed-off-by: w0wl0lxd <w0wl0lxd@tuta.com>

coderabbitai

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@plugins/task/init.lua`:
- Around line 151-165: Replace the background branch in the task handler with
the same detached subagent creation flow used by the synchronous path, invoking
n00n.agent.session(...) directly instead of creating a session with a
natural-language prompt. Preserve the background response contract while
ensuring subagent audience setup, early output_schema validation, and semaphore
gating occur during the initial spawn.
- Around line 277-297: Handle the result of the do_poll coroutine after
n00n.async.gather, rather than ignoring results[2]. If polling failures are not
best-effort, propagate results[2].err so the task fails; otherwise explicitly
log the polling error while preserving the existing prompt result handling.

In `@plugins/team/ibn.lua`:
- Around line 17-25: Update is_multi_step to match each MULTI_STEP keyword only
at a word boundary using Lua’s frontier pattern %f[%a], while preserving case
normalization and literal matching so substrings within larger words no longer
trigger a multi-step result.

In `@plugins/team/init.lua`:
- Line 396: Rename the unused input parameter in the finish_run function to
_input, preserving its position and all other parameters and behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 23f3af1f-eff6-4e35-bd88-60372c553b34

📥 Commits

Reviewing files that changed from the base of the PR and between e729ee1 and cedd72a.

📒 Files selected for processing (36)

AGENTS.md
n00n-config/src/lib.rs
n00n-docgen/src/gen_tools.rs
n00n-lua/src/api/agent.rs
n00n-lua/src/api/session.rs
n00n-lua/src/api/util/command.rs
n00n-lua/src/loader.rs
n00n-lua/tests/plugin_host.rs
n00n-lua/tests/spec.rs
n00n-lua/tests/task_policy.rs
n00n-ui/src/app/mod.rs
n00n-ui/src/app/mouse.rs
n00n-ui/src/app/tests.rs
n00n-ui/src/chat.rs
n00n-ui/src/components/command.rs
n00n-ui/src/components/messages/mod.rs
n00n-ui/src/components/messages/tests.rs
n00n-ui/src/components/status_bar.rs
n00n-ui/src/event_loop.rs
plugins/agent_control/init.lua
plugins/almas/refine.lua
plugins/lib/n00n/route_tier.lua
plugins/task/init.lua
plugins/team/ibn.lua
plugins/team/init.lua
plugins/team/mem.lua
plugins/team/quorum.lua
plugins/team/retrieve.lua
plugins/team/roles.lua
plugins/team/swarm.lua
plugins/team/tests/spec.lua
scripts/team_demo.sh
site/docs/content/commands/_index.md
site/docs/content/configuration/_index.md
site/docs/content/lua-api/_index.md
site/docs/content/tools/_index.md

💤 Files with no reviewable changes (2)

plugins/almas/refine.lua
plugins/team/tests/spec.lua

📜 Review details

⏰ Context from checks skipped due to timeout. (3)

GitHub Check: Lint (Windows)
GitHub Check: Build (Windows)
GitHub Check: Test

🧰 Additional context used

📓 Path-based instructions (7)

**/*.rs