Repository navigation
fix(team): resolve wave validator model - #138
Conversation
|
Warning Review limit reached
Next review available in: 56 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e969f61270
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| prompt = function() | ||
| return "PASS", nil | ||
| end, |
There was a problem hiding this comment.
When model resolution succeeds and a real validation prompt completes, n00n.agent.session():prompt returns a table whose response is in result.text (n00n-lua/src/api/agent.rs, prompt_result_table), not a string. Both new mocks return "PASS" directly, so the tests conceal that validate_wave subsequently invokes response:match(...) on the real table and crashes every successfully resolved validation. Make the mocks return { text = "PASS", ... } and update the validator to inspect res.text.
Useful? React with 👍 / 👎.
Resolve SessionRequest parent_id + steer/control and storage test imports.
1 participant
Summary
Context
Recent team runs repeatedly failed wave validation because the literal tier
strongwas passed as a model spec. Retries then consumed the team agent-call budget without validating completed work.Validation
stylua --check plugins/team/validation.lua plugins/team/tests/spec.luacargo test -p n00n-lua --test spec team_plugin_specgit diff --check