Change devcontainer to use image+features (dotnet#16335)

* Change devcontainer to use image+features * Update devcontainer.json * Fixes * Update devcontainer.json Co-authored-by: Petr <[email protected]> --------- Co-authored-by: Petr <[email protected]>
vzarytovskii · Dec 7, 2023 · dc40139 · dc40139
1 parent 9123c41
commit dc40139
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 38 deletions.
diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -1,13 +1,14 @@
 // For format details, see https://aka.ms/vscode-remote/devcontainer.json or this file's README at:
 {
-    "name": "F# (.NET 8)",
-    "build": {
-        "dockerfile": "Dockerfile",
-        "args": {
-            // Update 'VARIANT' to pick a .NET Core version: 3.1, 5.0, 6.0, 7.0, 8.0, etc.
-            // Append -bullseye(-slim), -focal, or -jammy to pin to an OS version.
-            "VARIANT": "8.0.100-rc.1-bookworm-slim-amd64"
-        }
+    "name": "F#",
+    "image": "mcr.microsoft.com/dotnet/sdk:8.0.100-rc.1",
+    "features": {
+        "ghcr.io/devcontainers/features/common-utils:2": {},
+        "ghcr.io/devcontainers/features/git:1": {},
+        "ghcr.io/devcontainers/features/github-cli:1": {
+            "version": "2"
+        },
+        "ghcr.io/devcontainers/features/dotnet:2": {}
     },
     "hostRequirements": {
         "cpus": 2,
@@ -18,13 +19,18 @@
         "vscode": {
             // Add the IDs of extensions you want installed when the container is created.
             "extensions": [
+                "GitHub.copilot",
+                "GitHub.vscode-github-actions",
+                "ms-dotnettools.vscode-dotnet-runtime",
+                "ms-dotnettools.csdevkit",
                 "ms-dotnettools.csharp",
                 "Ionide.Ionide-fsharp",
                 "tintoy.msbuild-project-tools"
             ]
         }
     },
-
-    "onCreateCommand": [ "dotnet", "build", "FSharp.Compiler.Service.sln"],
-    "waitFor": "onCreateCommand"
+    "remoteEnv": {
+        "TARGET": "net8.0"
+    },
+    "postCreateCommand": [ "dotnet", "build", "FSharp.Compiler.Service.sln"]
 }