Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the training end_e as the evaluation(..., epsilon=end_e) for atari #430

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cleanrl/c51_atari.py
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ def linear_schedule(start_e: float, end_e: float, duration: int, t: int):
run_name=f"{run_name}-eval",
Model=QNetwork,
device=device,
epsilon=0.05,
epsilon=args.end_e,
)
for idx, episodic_return in enumerate(episodic_returns):
writer.add_scalar("eval/episodic_return", episodic_return, idx)
Expand Down
2 changes: 1 addition & 1 deletion cleanrl/c51_atari_jax.py
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ def get_action(q_state, obs):
eval_episodes=10,
run_name=f"{run_name}-eval",
Model=QNetwork,
epsilon=0.05,
epsilon=args.end_e,
)
for idx, episodic_return in enumerate(episodic_returns):
writer.add_scalar("eval/episodic_return", episodic_return, idx)
Expand Down
2 changes: 1 addition & 1 deletion cleanrl/dqn_atari.py
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ def linear_schedule(start_e: float, end_e: float, duration: int, t: int):
run_name=f"{run_name}-eval",
Model=QNetwork,
device=device,
epsilon=0.05,
epsilon=args.end_e,
)
for idx, episodic_return in enumerate(episodic_returns):
writer.add_scalar("eval/episodic_return", episodic_return, idx)
Expand Down
2 changes: 1 addition & 1 deletion cleanrl/dqn_atari_jax.py
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ def mse_loss(params):
eval_episodes=10,
run_name=f"{run_name}-eval",
Model=QNetwork,
epsilon=0.05,
epsilon=args.end_e,
)
for idx, episodic_return in enumerate(episodic_returns):
writer.add_scalar("eval/episodic_return", episodic_return, idx)
Expand Down
6 changes: 3 additions & 3 deletions cleanrl/qdagger_dqn_atari_impalacnn.py
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ def kl_divergence_with_logits(target_logits, prediction_logits):
eval_episodes=args.teacher_eval_episodes,
run_name=f"{run_name}-teacher-eval",
Model=TeacherModel,
epsilon=0.05,
epsilon=args.end_e,
capture_video=False,
)
writer.add_scalar("charts/teacher/avg_episodic_return", np.mean(teacher_episodic_returns), 0)
Expand Down Expand Up @@ -342,7 +342,7 @@ def kl_divergence_with_logits(target_logits, prediction_logits):
run_name=f"{run_name}-eval",
Model=QNetwork,
device=device,
epsilon=0.05,
epsilon=args.end_e,
)
print(episodic_returns)
writer.add_scalar("charts/offline/avg_episodic_return", np.mean(episodic_returns), global_step)
Expand Down Expand Up @@ -459,7 +459,7 @@ def kl_divergence_with_logits(target_logits, prediction_logits):
run_name=f"{run_name}-eval",
Model=QNetwork,
device=device,
epsilon=0.05,
epsilon=args.end_e,
)
for idx, episodic_return in enumerate(episodic_returns):
writer.add_scalar("eval/episodic_return", episodic_return, idx)
Expand Down
6 changes: 3 additions & 3 deletions cleanrl/qdagger_dqn_atari_jax_impalacnn.py
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ def linear_schedule(start_e: float, end_e: float, duration: int, t: int):
eval_episodes=args.teacher_eval_episodes,
run_name=f"{run_name}-teacher-eval",
Model=TeacherModel,
epsilon=0.05,
epsilon=args.end_e,
capture_video=False,
)
writer.add_scalar("charts/teacher/avg_episodic_return", np.mean(teacher_episodic_returns), 0)
Expand Down Expand Up @@ -361,7 +361,7 @@ def loss(params, td_target, teacher_q_values, distill_coeff):
eval_episodes=10,
run_name=f"{run_name}-eval",
Model=QNetwork,
epsilon=0.05,
epsilon=args.end_e,
)
print(episodic_returns)
writer.add_scalar("charts/offline/avg_episodic_return", np.mean(episodic_returns), global_step)
Expand Down Expand Up @@ -469,7 +469,7 @@ def loss(params, td_target, teacher_q_values, distill_coeff):
eval_episodes=10,
run_name=f"{run_name}-eval",
Model=QNetwork,
epsilon=0.05,
epsilon=args.end_e,
)
for idx, episodic_return in enumerate(episodic_returns):
writer.add_scalar("eval/episodic_return", episodic_return, idx)
Expand Down
Loading