Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify syntax #334

Merged
merged 1 commit into from
Dec 28, 2022
Merged

chore: simplify syntax #334

merged 1 commit into from
Dec 28, 2022

Conversation

vwxyzjn
Copy link
Owner

@vwxyzjn vwxyzjn commented Dec 28, 2022

Description

This PR does a simple refactoring on the dataclass syntax in ppo_atari_envpool_xla_jax_scan.py.

Types of changes

  • Bug fix
  • New feature
  • New algorithm
  • Documentation
  • minor refactor

@vwxyzjn vwxyzjn requested a review from 51616 December 28, 2022 02:16
@vercel
Copy link

vercel bot commented Dec 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cleanrl ✅ Ready (Inspect) Visit Preview Dec 28, 2022 at 2:16AM (UTC)

Copy link
Collaborator

@51616 51616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vwxyzjn vwxyzjn merged commit d67ae0c into master Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants