Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors a few arguments in
parse_args()
:This PR moves the
![image](https://user-images.githubusercontent.com/5555347/155023370-5f678b87-3467-4c8d-a46f-73f70d6ebf69.png)
![image](https://user-images.githubusercontent.com/5555347/155023723-548220e3-3ce5-4325-8a36-ed367a243e2d.png)
gym_id
,learning_rate
,total_timesteps
move down to algorithm-specific arguments. Currently when doing a file diff betweenc51_atari.py
andppo_continuous_action.py
, we have the following screenshot:However, it's more desirable to all of the differences in one place, as shown below:
This PR also renames the
gym-id
toenv-id
. The reason is that as we adopt different environments, some of them don't necessarily have agym-id
but they have an environment name. For example, procgen has theenv-id
but notgym-id
.Curious about your thoughts @yooceii @dosssman on whether this is necessary.