Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gym version to 0.26.1 #263

Closed
1 of 2 tasks
Tracked by #115
AdityaGudimella opened this issue Aug 22, 2022 · 2 comments
Closed
1 of 2 tasks
Tracked by #115

Upgrade gym version to 0.26.1 #263

AdityaGudimella opened this issue Aug 22, 2022 · 2 comments

Comments

@AdityaGudimella
Copy link

Problem Description

Upgrade gym version used in cleanrl from 0.23.1 to 0.25.1

Checklist

Possible Solution

StabeBaselines' ReplayBuffer currently does not support the new format returned by gym.Env.step. Their step api changed from:
obs, rew, done, info = env.step(action) to obs, rew, terminated, truncated, info = env.step(action).
We would need to implement a slightly modified version of the ReplayBuffer in cleanRL itself. Other than this, the changes required are minimal.

I can submit an initial PR with changes required for SAC if you're interested.

@vwxyzjn
Copy link
Owner

vwxyzjn commented Sep 6, 2022

Update on the ticket - the current gym master is set to release 0.26.0 which enables obs, rew, terminated, truncated, info = env.step(action) by default.

@vwxyzjn vwxyzjn changed the title Upgrade gym version to 0.25.1 Upgrade gym version to 0.26.1 Oct 3, 2022
@vwxyzjn vwxyzjn mentioned this issue Oct 3, 2022
4 tasks
@vwxyzjn
Copy link
Owner

vwxyzjn commented Nov 28, 2023

#424 closes this issue to use gymnasium.

@vwxyzjn vwxyzjn closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants