Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Gymnasium-compliant PPO script #318

Closed
wants to merge 3 commits into from

Conversation

dtch1997
Copy link
Collaborator

@dtch1997 dtch1997 commented Nov 15, 2022

Description

This PR modifies ppo_continuous_action.py to work with Gymnasium environments.

Types of changes

  • Bug fix
  • New feature
  • New algorithm
  • Documentation

Checklist:

  • I've read the CONTRIBUTION guide (required).
  • I have ensured pre-commit run --all-files passes (required).
  • I have updated the documentation and previewed the changes via mkdocs serve.
  • I have updated the tests accordingly (if applicable).

If you are adding new algorithm variants or your change could result in performance difference, you may need to (re-)run tracked experiments. See #137 as an example PR.

  • I have contacted vwxyzjn to obtain access to the openrlbenchmark W&B team (required).
  • I have tracked applicable experiments in openrlbenchmark/cleanrl with --capture-video flag toggled on (required).
  • I have added additional documentation and previewed the changes via mkdocs serve.
    • I have explained note-worthy implementation details.
    • I have explained the logged metrics.
    • I have added links to the original paper and related papers (if applicable).
    • I have added links to the PR related to the algorithm variant.
    • I have created a table comparing my results against those from reputable sources (i.e., the original paper or other reference implementation).
    • I have added the learning curves (in PNG format).
    • I have added links to the tracked experiments.
    • I have updated the overview sections at the docs and the repo
  • I have updated the tests accordingly (if applicable).

@vercel
Copy link

vercel bot commented Nov 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cleanrl ✅ Ready (Inspect) Visit Preview Nov 15, 2022 at 2:12AM (UTC)

@dtch1997
Copy link
Collaborator Author

@vwxyzjn
Copy link
Owner

vwxyzjn commented Nov 15, 2022

@dtch1997 thanks for this PR. Great work! Your work also made me realize we could probably support gym and gymnasium simultaneously since they have different package names. We could probably save all of the gymnasium scripts under the gymnasium folder and then gradually migrate to gymnasium. #277 #263

@vwxyzjn vwxyzjn mentioned this pull request Nov 15, 2022
21 tasks
@vwxyzjn
Copy link
Owner

vwxyzjn commented Nov 15, 2022

Let me fix the CI

@vwxyzjn
Copy link
Owner

vwxyzjn commented Nov 15, 2022

@dtch1997 could you give me write access to the branch?
Screen Shot 2022-11-14 at 9 32 06 PM 1

@dtch1997
Copy link
Collaborator Author

@vwxyzjn the option doesn't show up for me, after following Github docs: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

I added you as a collaborator on the downstream fork instead, does that help?

Screenshot from 2022-11-15 12-43-59

@vwxyzjn
Copy link
Owner

vwxyzjn commented Nov 15, 2022

Thanks for giving it a try but it wasn't quite working...

image

I think the "allow edits from maintainer" option wasn't there because the PR is based on your master branch. Would you mind creating another branch and filing another PR?

@dtch1997 dtch1997 closed this Nov 15, 2022
@dtch1997
Copy link
Collaborator Author

Closed as a duplicate of #319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants