-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Gymnasium-compliant PPO script #318
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Experiments ongoing: https://wandb.ai/dtch1997/cleanRL?workspace=user-dtch1997 |
@dtch1997 thanks for this PR. Great work! Your work also made me realize we could probably support gym and gymnasium simultaneously since they have different package names. We could probably save all of the gymnasium scripts under the gymnasium folder and then gradually migrate to gymnasium. #277 #263 |
Let me fix the CI |
@dtch1997 could you give me write access to the branch? |
@vwxyzjn the option doesn't show up for me, after following Github docs: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork I added you as a collaborator on the downstream fork instead, does that help? |
Closed as a duplicate of #319 |
Description
This PR modifies
ppo_continuous_action.py
to work with Gymnasium environments.Types of changes
Checklist:
pre-commit run --all-files
passes (required).mkdocs serve
.If you are adding new algorithm variants or your change could result in performance difference, you may need to (re-)run tracked experiments. See #137 as an example PR.
--capture-video
flag toggled on (required).mkdocs serve
.