Proper description of v_min and v_max in C51 parser (#343)

* fix typo * c51 typo
vwxyzjn · Jan 9, 2023 · 3f5535c · 3f5535c · vercel · Jan 9, 2023
1 parent 94a44b5
commit 3f5535c
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/cleanrl/c51.py b/cleanrl/c51.py
@@ -44,9 +44,9 @@ def parse_args():
     parser.add_argument("--n-atoms", type=int, default=101,
         help="the number of atoms")
     parser.add_argument("--v-min", type=float, default=-100,
-        help="the number of atoms")
+        help="the return lower bound")
     parser.add_argument("--v-max", type=float, default=100,
-        help="the number of atoms")
+        help="the return upper bound")
     parser.add_argument("--buffer-size", type=int, default=10000,
         help="the replay memory buffer size")
     parser.add_argument("--gamma", type=float, default=0.99,

diff --git a/cleanrl/c51_atari.py b/cleanrl/c51_atari.py
@@ -51,9 +51,9 @@ def parse_args():
     parser.add_argument("--n-atoms", type=int, default=51,
         help="the number of atoms")
     parser.add_argument("--v-min", type=float, default=-10,
-        help="the number of atoms")
+        help="the return lower bound")
     parser.add_argument("--v-max", type=float, default=10,
-        help="the number of atoms")
+        help="the return upper bound")
     parser.add_argument("--buffer-size", type=int, default=1000000,
         help="the replay memory buffer size")
     parser.add_argument("--gamma", type=float, default=0.99,

diff --git a/cleanrl/c51_atari_jax.py b/cleanrl/c51_atari_jax.py
@@ -58,9 +58,9 @@ def parse_args():
     parser.add_argument("--n-atoms", type=int, default=51,
         help="the number of atoms")
     parser.add_argument("--v-min", type=float, default=-10,
-        help="the number of atoms")
+        help="the return lower bound")
     parser.add_argument("--v-max", type=float, default=10,
-        help="the number of atoms")
+        help="the return upper bound")
     parser.add_argument("--buffer-size", type=int, default=1000000,
         help="the replay memory buffer size")
     parser.add_argument("--gamma", type=float, default=0.99,

diff --git a/cleanrl/c51_jax.py b/cleanrl/c51_jax.py
@@ -47,9 +47,9 @@ def parse_args():
     parser.add_argument("--n-atoms", type=int, default=101,
         help="the number of atoms")
     parser.add_argument("--v-min", type=float, default=-100,
-        help="the number of atoms")
+        help="the return lower bound")
     parser.add_argument("--v-max", type=float, default=100,
-        help="the number of atoms")
+        help="the return upper bound")
     parser.add_argument("--buffer-size", type=int, default=10000,
         help="the replay memory buffer size")
     parser.add_argument("--gamma", type=float, default=0.99,