Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples clear and ssh connection close #23

Merged
merged 2 commits into from
Mar 6, 2016
Merged

Add examples clear and ssh connection close #23

merged 2 commits into from
Mar 6, 2016

Conversation

achaussier
Copy link
Contributor

This resolve #22 :

  • Always clear examples between runs
  • Close existing SSH connection between runs

This resolve #22 :
- Always clear examples between runs
- Close existing SSH connection between runs
@vainikkaj
Copy link

Good stuff, unfortunately this breaks Vagrant when shared examples are used.
Full error available in https://gist.github.com/vainikkaj/021ecf1a216d5448f782

Vagrant 1.8.1
Host: Windows 7
Guest: Windows 2012r2

@vainikkaj
Copy link

Everything works again after shared examples are loaded using load instead of require

@achaussier
Copy link
Contributor Author

Hello,
Thanks, good to know. I'll add a commit to update readme file today and add a note about that point.

@vvchik
Copy link
Owner

vvchik commented Jan 12, 2016

Looks good, please update Readme and I will merge it.

@achaussier
Copy link
Contributor Author

Readme updated.

@achaussier
Copy link
Contributor Author

Hello, @vvchik, can you have some time to merge it if all is always ok ?

Thanks

vvchik added a commit that referenced this pull request Mar 6, 2016
Add examples clear and ssh connection close
@vvchik vvchik merged commit 2cffd41 into vvchik:master Mar 6, 2016
@vvchik
Copy link
Owner

vvchik commented Mar 6, 2016

Done, sorry I missed your update in readme

@achaussier
Copy link
Contributor Author

No problem, thanks 👍

Have a nice day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using two serverspec suites on two separate VMs
3 participants