Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linter): change linter from golint to revive #60

Merged
merged 6 commits into from
Dec 26, 2021

Conversation

MaineK00n
Copy link
Collaborator

@MaineK00n MaineK00n commented Sep 19, 2021

What did you implement:

Change the linter to revive, since golint has been deprecated as follows.

NOTE: Golint is deprecated and frozen. There's no drop-in replacement for it, but tools such as Staticcheck and go vet should be used instead.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

$ make lint
$ golangci-lint run -c .golangci.yml

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this Sep 19, 2021
@MaineK00n MaineK00n force-pushed the MaineK00n/change-linter-revive branch from 218a2cb to bc6a515 Compare November 15, 2021 22:54
@MaineK00n MaineK00n changed the title [WIP] chore(linter): change linter from golint to revive chore(linter): change linter from golint to revive Dec 8, 2021
@kotakanbe kotakanbe merged commit ae0f310 into master Dec 26, 2021
@kotakanbe kotakanbe deleted the MaineK00n/change-linter-revive branch December 26, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants