Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): use go-git v5 #208

Merged
merged 1 commit into from
Jun 14, 2024
Merged

chore(deps): use go-git v5 #208

merged 1 commit into from
Jun 14, 2024

Conversation

MaineK00n
Copy link
Collaborator

@MaineK00n MaineK00n commented Jun 13, 2024

What did you implement:

Fixes:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

$ docker run --rm -it alpine:3.20 sh
/ # apk add --no-cache go make
/ # wget https://github.com/vulsio/go-exploitdb/archive/refs/heads/MaineK00n/go-git-v5.tar.gz
/ # tar -xvf go-git-v5.tar.gz
/ # cd go-exploitdb-MaineK00n-go-git-v5/
/go-exploitdb-MaineK00n-go-git-v5 # git
sh: git: not found
/go-exploitdb-MaineK00n-go-git-v5 # make build

// first fetch: clone to ~/.cache/go-exploitdb/pocs
/go-exploitdb-MaineK00n-go-git-v5 # ./go-exploitdb fetch githubrepos

// replace ~/.cache/go-exploitdb/pocs with the outdated commit 
/go-exploitdb-MaineK00n-go-git-v5 # cd ~/.cache/go-exploitdb/pocs
~/.cache/go-exploitdb/pocs # apk add --no-cache git
~/.cache/go-exploitdb/pocs # git reset --hard 6168e2025ba3fd0cf34239b31e862a64ac5416c0
~/.cache/go-exploitdb/pocs # apk del git
~/.cache/go-exploitdb/pocs # cd /go-exploitdb-MaineK00n-go-git-v5/

// Second and subsequent fetches: pull ~/.cache/go-exploitdb/pocs
/go-exploitdb-MaineK00n-go-git-v5 # ./go-exploitdb fetch githubrepos

// pull success: check ~/.cache/go-exploitdb/pocs commit hash
/go-exploitdb-MaineK00n-go-git-v5 # cd ~/.cache/go-exploitdb/pocs
~/.cache/go-exploitdb/pocs # apk add --no-cache git
~/.cache/go-exploitdb/pocs # git log -n 2
commit 554be9b7a945b07553637ea35c96419c99f5ff67 (HEAD -> master, origin/master)
Author: motikan2010-bot <[email protected]>
Date:   Thu Jun 13 21:29:56 2024 +0900

    Auto Update 2024/06/13 12:29:56

commit 6168e2025ba3fd0cf34239b31e862a64ac5416c0
Author: motikan2010-bot <[email protected]>
Date:   Thu Jun 13 15:29:29 2024 +0900

    Auto Update 2024/06/13 06:29:29

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n requested a review from shino June 13, 2024 18:16
@MaineK00n MaineK00n self-assigned this Jun 13, 2024
Copy link
Contributor

@shino shino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tooooo sloooooow but it works as expected!!

@MaineK00n MaineK00n merged commit b1445b9 into master Jun 14, 2024
6 checks passed
@MaineK00n MaineK00n deleted the MaineK00n/go-git-v5 branch June 14, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants