Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: select advisories #396

Merged
merged 1 commit into from
Jul 8, 2024
Merged

feat: select advisories #396

merged 1 commit into from
Jul 8, 2024

Conversation

MaineK00n
Copy link
Collaborator

@MaineK00n MaineK00n commented Jul 5, 2024

If this Pull Request is work in progress, Add a prefix of “[WIP]” in the title.

What did you implement:

select advisories and related cve ids

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

$ go-cve-dictionary fetch jvn 2024
$ go-cve-dictionary search advisories jvn
{
  "JVNDB-2024-000001": [
    "CVE-2024-22027"
  ],
  "JVNDB-2024-000002": [
    "CVE-2024-22028"
  ],
  "JVNDB-2024-000003": [
    "CVE-2024-21584"
  ],
...

$ docker run --rm --name redis -d -p 127.0.0.1:6379:6379 redis
$ go-cve-dictionary fetch jvn 2024 --dbtype redis --dbpath "redis://127.0.0.1:6379/1"
$ go-cve-dictionary search advisories jvn --dbtype redis --dbpath "redis://127.0.0.1:6379/1"
{
  "JVNDB-2024-000001": [
    "CVE-2024-22027"
  ],
  "JVNDB-2024-000002": [
    "CVE-2024-22028"
  ],
  "JVNDB-2024-000003": [
    "CVE-2024-21584"
  ],
...

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this Jul 5, 2024
@MaineK00n MaineK00n force-pushed the MaineK00n/select-advisories branch from 09c5b90 to fc3d303 Compare July 5, 2024 10:16
@MaineK00n MaineK00n marked this pull request as ready for review July 5, 2024 10:23
@MaineK00n MaineK00n requested a review from shino July 5, 2024 10:23
Copy link
Collaborator

@shino shino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!!

@MaineK00n MaineK00n merged commit dbdd7b4 into master Jul 8, 2024
6 checks passed
@MaineK00n MaineK00n deleted the MaineK00n/select-advisories branch July 8, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants