Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vulkano-derive with custom derive for Vertex #1327

Closed
wants to merge 2 commits into from
Closed

Add vulkano-derive with custom derive for Vertex #1327

wants to merge 2 commits into from

Conversation

jmi2k
Copy link
Contributor

@jmi2k jmi2k commented Feb 15, 2020

  • Added an entry to CHANGELOG_VULKANO.md or CHANGELOG_VK_SYS.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes - in this repository
  • Updated documentation to reflect any user-facing changes - PR to the guide that fixes existing documentation invalidated by this PR.

WIP. Currently it does the same as impl_vertex! but as a derive macro. There is a lot of room left to improve the code, and even use features only available to procedural macros.

@jmi2k
Copy link
Contributor Author

jmi2k commented Feb 21, 2020

Right now an implementation of Default is required for the vertex struct, in order to make the macro work. It cannot be removed AFAIK because we use a dummy instance of it to calculate offsets for each of the members, which is impossible to do right now without an existing value of the struct (there are attempts out there using raw pointers and uninitialized data, but right now they rely on undefined behavior more or less. We'll have to keep an eye at this issue).

I'd like to remove that restriction in the future, but right now we'll have to live with it.

@@ -0,0 +1,19 @@
[package]
name = "vulkano-derive"
version = "0.17.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vulkano 0.18 is the current release.

@AustinJ235
Copy link
Member

Aside from the mismatched version there are some issues with adding another crate. Version publishing is automatically handled by travis ci, so that'll need to be updated via the travis config to publish that also.

@Eliah-Lakhin
Copy link
Contributor

Perhaps, the goal if this PR is already at least partially covered by my other PR #1460 that now allows custom derives in existing macro(from vulkano-shaders crate).

Also to mention, that now we(maintainers) have capabilities to maintain crates.io publishings directly(thanks to Tomaka, the owner of the project), so the issue with the side crates is probably not that big deal now, however I would suggest to avoid of adding additional crates to the project ecosystem whenever it possible. It might complicate maintainability.

There were no updates in the Pull Request nor comments about the development progress from the author( @jmi2k ) quite a while. It seems like the development was abandoned. As such I would like to close the PR for now. If the development continues please reopen the Pull Request again. We are glad to accept any infrastructure improvements that could benefit Vulkano user community experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants