-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vulkano-derive with custom derive for Vertex #1327
Conversation
Right now an implementation of I'd like to remove that restriction in the future, but right now we'll have to live with it. |
@@ -0,0 +1,19 @@ | |||
[package] | |||
name = "vulkano-derive" | |||
version = "0.17.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vulkano 0.18 is the current release.
Aside from the mismatched version there are some issues with adding another crate. Version publishing is automatically handled by travis ci, so that'll need to be updated via the travis config to publish that also. |
Perhaps, the goal if this PR is already at least partially covered by my other PR #1460 that now allows custom derives in existing macro(from vulkano-shaders crate). Also to mention, that now we(maintainers) have capabilities to maintain crates.io publishings directly(thanks to Tomaka, the owner of the project), so the issue with the side crates is probably not that big deal now, however I would suggest to avoid of adding additional crates to the project ecosystem whenever it possible. It might complicate maintainability. There were no updates in the Pull Request nor comments about the development progress from the author( @jmi2k ) quite a while. It seems like the development was abandoned. As such I would like to close the PR for now. If the development continues please reopen the Pull Request again. We are glad to accept any infrastructure improvements that could benefit Vulkano user community experience. |
CHANGELOG_VULKANO.md
orCHANGELOG_VK_SYS.md
if knowledge of this change could be valuable to usersWIP. Currently it does the same as
impl_vertex!
but as a derive macro. There is a lot of room left to improve the code, and even use features only available to procedural macros.