Skip to content

Conversation

@jacekkarczmarczyk
Copy link
Member

@jacekkarczmarczyk jacekkarczmarczyk commented Aug 15, 2018

Motivation and Context

image

How Has This Been Tested?

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have created a PR in the documentation with the necessary changes.

Docs

https://github.com/vuetifyjs/vuetifyjs.com/pull/572

Comments

Requires change in vuetifyjs/vue-cli-plugins#28

@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Aug 15, 2018
@jacekkarczmarczyk jacekkarczmarczyk added this to the v1.2.0 milestone Aug 15, 2018
johnleider
johnleider previously approved these changes Aug 17, 2018
@KaelWD KaelWD added T: task S: has merge conflicts The pending Pull Request has merge conflicts labels Aug 17, 2018
@jacekkarczmarczyk jacekkarczmarczyk force-pushed the refactor/typescript-locale branch from 7bb60c9 to 751bc11 Compare August 17, 2018 15:20
@jacekkarczmarczyk jacekkarczmarczyk removed the S: has merge conflicts The pending Pull Request has merge conflicts label Aug 17, 2018
KaelWD
KaelWD previously requested changes Aug 18, 2018
Copy link
Member

@KaelWD KaelWD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change gr and pl permissions back to 644

@codecov
Copy link

codecov bot commented Aug 18, 2018

Codecov Report

Merging #4876 into dev will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4876      +/-   ##
==========================================
+ Coverage   88.96%   89.09%   +0.12%     
==========================================
  Files         227      228       +1     
  Lines        5376     5430      +54     
  Branches     1362     1387      +25     
==========================================
+ Hits         4783     4838      +55     
+ Misses        475      474       -1     
  Partials      118      118
Impacted Files Coverage Δ
src/locale/en.ts 100% <ø> (ø)
src/mixins/measurable.ts 100% <0%> (ø)
src/components/VImg/VImg.ts 98.94% <0%> (+0.64%) ⬆️
src/components/VCard/VCard.ts 100% <0%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3fc07...0197865. Read the comment docs.

@KaelWD KaelWD merged commit bdaaffc into dev Aug 18, 2018
@KaelWD KaelWD deleted the refactor/typescript-locale branch August 18, 2018 08:31
@KaelWD KaelWD mentioned this pull request Aug 18, 2018
9 tasks
@lock
Copy link

lock bot commented Apr 15, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants