Skip to content

Conversation

@Haviles04
Copy link
Contributor

@Haviles04 Haviles04 commented Sep 23, 2025

Fixes regression introduced by #22082 issue #22071

Description

Changed order so tabindex will overwrite the tabindex inside linkProps

Markup:

<template>
  <v-app>
    <v-container>
      <v-select
        :items="['California', 'Colorado', 'Florida', 'Georgia', 'Texas', 'Wyoming']"
        label="Select"
      />
    </v-container>
  </v-app>
</template>

<script setup lang="ts">

</script>

@Haviles04 Haviles04 changed the title V-list-item tab order fix fix: V-list-item tab order Sep 23, 2025
@Haviles04 Haviles04 changed the title fix: V-list-item tab order fix: V-list-item tabindex Sep 23, 2025
@Haviles04 Haviles04 changed the title fix: V-list-item tabindex fix: (VListItem) fix incorrect tab index Sep 23, 2025
@Haviles04 Haviles04 requested review from a team, J-Sek and johnleider September 23, 2025 14:53
@J-Sek
Copy link
Contributor

J-Sek commented Sep 23, 2025

I see the same order (tabindex={ ... } before { ...link.linkProps }) in VCard, VBtn and VChip. We might need to update those places - either by removing tabindex that's going to be overwritten by link props, or repeating the fix for VListItem.

TBH, it looks a bit brittle. Could we make it a parameter of useLink(...) instead?

@KaelWD KaelWD closed this in 9a844f6 Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants