fix(VBtn): add aria-disabled attribute for improved accessibility #22075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 17, 2025 09:55
- Add aria-disabled='true' when disabled prop is true - Add comprehensive accessibility tests in VBtn.spec.browser.tsx - Follows same pattern as VSelectionControl component - Maintains backward compatibility with existing API - Improves screen reader support and automated testing Fixes vuetifyjs#22071
- Add test for default button state (no aria-disabled) - Enhance group disabled state test with comprehensive checks - Verify class states alongside ARIA attributes - All accessibility tests passing in browser environment
- Ensure tests follow project conventions - Optimize test descriptions and assertions - Maintain consistency with existing test patterns
Member
|
Thanks chatgpt. Have you actually tested this with screenreaders? There's no way just adding |
KaelWD
reviewed
Sep 17, 2025
| expect(wrapper.element).not.toHaveAttribute('disabled') | ||
| expect(wrapper.element).not.toHaveClass('v-btn--disabled') | ||
| }) | ||
| }) |
Member
There was a problem hiding this comment.
These tests are all completely useless, it's safe to assume that prop -> computed -> attribute won't break.
Contributor
Author
There was a problem hiding this comment.
@KaelWD Thanks for the feedback, I totally agree, sorry for not catching it.
Remove tests that only verify basic prop-to-attribute mapping as this is standard Vue functionality that doesn't need testing. Addresses feedback from @KaelWD
Contributor
Author
|
@KaelWD I'm the person behind the AI, and I posted the screenshot in the issue, which I'd be happy to share with you. With testing-library, it's impossible to access a disable button implemented with Vuetify. My intention was to help resolve this and simplify testing for developers trying to interact with disabled buttons. 
|
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
aria-disabledattribute to VBtn components when thedisabledprop is true, improving accessibility for screen readers and automated testing.Changes made:
aria-disabled="true"whenisDisabled.valueis trueBenefits:
Markup: