Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Style action buttons of v-confirm-edit #20704

Closed
septatrix opened this issue Nov 15, 2024 · 2 comments
Closed

[Feature Request] Style action buttons of v-confirm-edit #20704

septatrix opened this issue Nov 15, 2024 · 2 comments

Comments

@septatrix
Copy link

Problem to solve

Currently one has no control over the style (e.g. variant) of the buttons of the v-confirm-edit component. The only solution currently is to create both buttons fully manually and use the save/cancel functions provided by the default slot.

Proposed solution

Expose props like button-variant et al on the confirm-edit element. Alternatively it would be great if options passed to the <component :is="actions" variant="... /* does not work */" /> would simply get picked up

@MatthewAry
Copy link
Contributor

Good one! I do want to point out that the default slot also provides you with these props:

save: () => void
cancel: () => void
isPristine: boolean

properties. Which makes it so you wouldn't have to use the actions prop to create the buttons. Though according to the documentation, it doesn't indicate that isPristine is reactive, which I think would be necessary for determining if the button is disabled or not.

Here is an example:
https://play.vuetifyjs.com/playgrounds/WWr9yA

@KaelWD KaelWD self-assigned this Nov 20, 2024
@KaelWD KaelWD added this to the v3.7.x milestone Nov 20, 2024
@KaelWD
Copy link
Member

KaelWD commented Nov 20, 2024

it doesn't indicate that isPristine is reactive

Everything in slot props is reactive.

@KaelWD KaelWD closed this as completed in 7aae81e Nov 20, 2024
KaelWD added a commit to J-Sek/vuetify that referenced this issue Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants