Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report][3.6.3] Badge does not use $badge-font-family #19834

Closed
simonflick opened this issue May 18, 2024 · 0 comments · Fixed by #20709
Closed

[Bug Report][3.6.3] Badge does not use $badge-font-family #19834

simonflick opened this issue May 18, 2024 · 0 comments · Fixed by #20709
Assignees
@yuwu9145
Labels
C: VBadge VBadge S: has PR The issue has a pending Pull Request sass T: enhancement Functionality that enhances existing features
Milestone
v3.7.x

Comments

@simonflick
Copy link

simonflick commented May 18, 2024 •
edited by J-Sek
Loading

Environment

Vuetify Version: 3.6.3
Vue Version: 3.4.26
Browsers: Firefox 126.0
OS: Windows 10

Steps to reproduce

Override the SCSS variable $badge-font-family.

Expected Behavior

The badge font should change.

Actual Behavior

Does not change.

Reproduction Link

Example on Stackblitz

Other comments

If you look into packages/vuetify/src/components/VBadge/VBadge.sass the variable is not used at all.
@github-actions github-actions bot added the S: stale This issue is untriaged and hasn't seen any activity in at least six months. label Nov 16, 2024
@J-Sek J-Sek added C: VBadge VBadge sass and removed S: stale This issue is untriaged and hasn't seen any activity in at least six months. labels Nov 16, 2024
@J-Sek J-Sek mentioned this issue Nov 16, 2024
Merged
@J-Sek J-Sek removed the S: triage label Nov 16, 2024
@J-Sek J-Sek added S: has PR The issue has a pending Pull Request and removed S: triage labels Nov 16, 2024
KaelWD pushed a commit that referenced this issue Nov 20, 2024
@J-Sek
fix(VBadge): restore unused SASS variables (#20709)
fd844e1 
resolves #19834
@KaelWD KaelWD added this to the v3.7.x milestone Nov 20, 2024
@KaelWD KaelWD added the T: enhancement Functionality that enhances existing features label Nov 20, 2024
KaelWD pushed a commit to J-Sek/vuetify that referenced this issue Nov 27, 2024
@J-Sek @KaelWD
fix(VBadge): restore unused SASS variables (vuetifyjs#20709)
bb7795e 
resolves vuetifyjs#19834
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuwu9145 yuwu9145

Labels
C: VBadge VBadge S: has PR The issue has a pending Pull Request sass T: enhancement Functionality that enhances existing features
Projects
None yet
Milestone
v3.7.x
Development

Successfully merging a pull request may close this issue.

fix(VBadge): restore unused SASS variables J-Sek/vuetify
4 participants
@yuwu9145 @KaelWD @simonflick @J-Sek