-
-
Notifications
You must be signed in to change notification settings - Fork 126
Conversation
Nice! I'll review it ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with microdatas, but I've just read several articles and schema.org's docs these days. Here's some questions:
Why not adding publisher
property to author, too?
Is dateModified
really required since we're currently only displaying published date?
I wasn't really sure of how to use the microdata properly, but sure we can add it.
You're right, it's not displayed but I thought it can be intersting to still have the info somewhere. |
IMO, we can provide an option whether to display last modified date, but it'll be another PR or issue, so leave |
Cool, could you remove |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks a lot.
Summary
This PR adds some microdatas on post and posts list. Microdatas are useful for search engines/web crawlers and can improve your position on search engines or the user experience.
Here are some screenshots on the Google's Structured data Testing tool:
Homepage (before):
Homepage (after):
Post (before):
Post (after):
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
No UI changes.
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
Nope.