Generalized support for code highlighting #696
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR GH-690 introduces the addition of 'py' to help label python-highlighted code in a document. I extend this idea by creating a Stylus variable to represent all default labels, and can be easily changed via
override.styl
.What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
Reason: Currently the default theme uses a list of labels (line 98 in
code.styl
) to determine which code blocks will include the label in the top right corner. I think moving this list intoconfig.styl
and assigning a variable (named$codeLang
) is better for a couple of reasons:override.styl
. I think everyone will have different use cases for Vuepress, so they may choose to use only certain code languages. For example, a front-end heavy documentation may use lots of js, ts, etc, whereas a back-end heavy documentation may use go, python, rust.To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: