Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: warn of styling config restriction (close #1889) #2161

Merged
merged 1 commit into from
Aug 22, 2020

Conversation

billyyyyy3320
Copy link
Collaborator

Summary

Relevant issue #1889

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@billyyyyy3320 billyyyyy3320 force-pushed the doc/style branch 3 times, most recently from 4351715 to 469ab0d Compare January 31, 2020 16:09
@billyyyyy3320
Copy link
Collaborator Author

@meteorlxy Thanks for the review, I've just updated it.

@meteorlxy
Copy link
Member

Maybe we should add a tip for how to import .css files?

For example: in enhanceApp.js?

@meteorlxy
Copy link
Member

meteorlxy commented Feb 2, 2020

Another point, relative .css file is not supported. How about css file form npm packages? 🤔 It might work. I'm going to have a try

@meteorlxy
Copy link
Member

I tried with github-markdown-css

Add following snippet in .vuepress/styles/index.styl:

@require '~github-markdown-css/github-markdown.css'

Things work well.

So I think we need to make the tip more specific @newsbielt703

@billyyyyy3320
Copy link
Collaborator Author

@meteorlxy Cool! And the point is only relative path is invalid, so using webpack alias to make it an absolute path is a solution. I've updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants