-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix($theme-default): Make navbar dropdown links accessible #1837
Merged
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
311f11f
#1818 | Make Accessibility Elements in navbar
edisdev 44462b6
fix: Change to dropdownlink test
edisdev 3593b4b
fix: change to testing for dropdownlink component
edisdev e996d18
Merge branch 'accessibility-dropdown' of https://github.com/edisdev/v…
edisdev 510be5b
feat: addauto opened & focus dropdown menu when keypress tab
edisdev 380911d
fix: update test for dropdownLink
edisdev fd30a60
edit tabindex to navlink & dropdownlink for not focusable
edisdev 8bd733f
Update docs for notFocusable props
edisdev 1b38f36
Update dropdownlink test
edisdev a5a66f1
Add keypress method in navlink and remove tabindex
edisdev 0a27789
Rename navlink & dropdown action / computed and bugfix for find last …
edisdev 96b1287
Make ariaLabel config for dropdown
edisdev c67010e
fix typo
edisdev e84b6c6
fix typo dropdown computed
edisdev 6da2e5f
edit language dropdown aria-label default value
edisdev 842157d
update docs for ariaLabel property
edisdev 371af79
feat: Try to improve code readability
kefranabg 0ef66cc
add aria-label property in docs page (theme)
edisdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need an entire section for
aria-label
😉 What I meant was just addingariaLabel: 'Language Menu'
in existing examples in this page. And I think you can do the same for Chineese. Sorry I wasn't clear about this 😛There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okey, i wil add that in existing examples :)