Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: search box max suggestions not working as expected #1728

Merged
merged 8 commits into from
Sep 10, 2019
Merged

fix: search box max suggestions not working as expected #1728

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
45f6393
Default theme is not work as expected
vrjuliao Jul 29, 2019
7aa9753
chore(search): fix search const vars and test
Sep 7, 2019
a866cc2
Merge branch 'master' into patch-1
vrjuliao Sep 10, 2019
b65c9ed
lintfying code
vrjuliao Sep 10, 2019
bc64a42
Fixing code formating
vrjuliao Sep 10, 2019
233bed0
Fixing bug 'this' pointer
vrjuliao Sep 10, 2019
776aae8
fix: searchBox plugin maxSuggestions solved
vrjuliao Sep 10, 2019
d71fb92
fix: SearchBox plugin themConfig.maxSuggestion
vrjuliao Sep 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@vuepress/plugin-search/SearchBox.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export default {
}

const { pages } = this.$site
const max = SEARCH_MAX_SUGGESTIONS
const max = this.$site.themeConfig.searchMaxSuggestions || SEARCH_MAX_SUGGESTIONS
const localePath = this.$localePath
const matches = item => (
item.title
Expand Down