-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #764 : implement support for external links in sidebar #1012
Conversation
We introduce a new type of sidebar item called 'external' which are treated differently in Sidebar/SidebarLink. These items are rendered as <a> elements with an added icon indicating that the element points to an external location.
fb5730e
to
5e47087
Compare
Any chance of this making it into |
6c3127f
to
71574f2
Compare
+1 for this! |
316e022
to
1284944
Compare
@rasapetter can you please rebase? |
@ulivz Any plans to merge this soon? |
+1 if you can, on the merge - I'm another who needs this. The case is an obvious one:
p.s. what I'm doing should soon be interesting to Gridsome and Vue |
The problem is the branch contains conflicts and it's even not working. I've tested it with the latest version. I've found the missing piece to get it working "again". I've actually an additional use case which I would like to pick up in case I will send my PR. This is my use case: What do you think? |
@timaschew very good to hear your progress, is the first thought, and a wish I wasn't so occupied that I could jump in on this. It's a basic need, wherever the routers of these SPA systems get hold of browser targetting -- and should be very solvable via the router access itself. It can be stopped in its tracks via the callbacks, and that's where I'd think to intervene, and presume this does, with too many other codebases open to give this one the attention. The doctor is operating...patient gets first care. We hope...!! I don't quite understand your use case, but appreciate, esp. the difficulty across languages; long life in Europe. But I'm sure it is quite sensiblle, and that many others are quietly mystified that there is this problem. We all tend to design first for the problem we think we are solving, and that's what happens with these powerful and focused applications.. Best, then, and encouragement -- and thanks. |
Let's do step by step: #1534 |
Closing in favor of #1534 |
Closes #764
Summary
We introduce a new type of sidebar item called 'external' which are
treated differently in Sidebar/SidebarLink. These items are rendered
as elements with an added icon indicating that the element points
to an external location.
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: