Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Ability to disable edit links on specific pages. #284

Closed
achendrick opened this issue Apr 27, 2018 · 1 comment · Fixed by #286
Closed

Feature Request: Ability to disable edit links on specific pages. #284

achendrick opened this issue Apr 27, 2018 · 1 comment · Fixed by #286
Labels
contribution welcome Contributions welcome

Comments

@achendrick
Copy link
Contributor

achendrick commented Apr 27, 2018 •
edited
Loading

The majority of the pages on my site will be in a submodule that will be publicly available for editing, while others will be in a private repo that should be maintained privately along with other source.

I'd like to remove the edit links from these private pages so it's not confusing when those pages reach a 404 as they won't exist in the submodule.
@yyx990803 yyx990803 added the contribution welcome Contributions welcome label Apr 27, 2018
achendrick added a commit to achendrick/vuepress that referenced this issue Apr 27, 2018
@achendrick
feat: hide edit link by page (close: vuejs#284)
ebc0953
@achendrick achendrick mentioned this issue Apr 27, 2018
Merged
ulivz pushed a commit that referenced this issue Apr 28, 2018
@achendrick @ulivz
feat: hide edit link by page (close: #284) (#286)
d46819c
@ulivz ulivz mentioned this issue May 11, 2018
Closed
@ulivz
Copy link
Member

ulivz commented May 11, 2018

Will release it at 0.9.0: #419. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome Contributions welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: hide edit link by page (close: #284) achendrick/vuepress
3 participants
@yyx990803 @achendrick @ulivz