fix($core): check if meta is from head before removing it #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
18 tasks
|
Hey @newsbielt703, do you think you can merge this? |
ulivz
reviewed
Jun 13, 2020
Co-authored-by: ULIVZ <[email protected]>
ulivz
approved these changes
Jun 13, 2020
larionov
pushed a commit
to larionov/vuepress
that referenced
this pull request
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@chriscdn opened this vuepress/vuepress-theme-blog#78, he is having an issue with
<meta>trying to be removed fromdocument.headwhereas they where notdocument.head's children.This can happens when you use
<meta>in<body>for microdatas. This is automatically done by the blog plugin since vuepress/vuepress-theme-blog#64.After the fix, global
<meta>and<meta>in<body>are still at the good place:What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
I would like to add a test to prevent a regression, but it looks like there is not tests for
core/lib/client/*.. or maybe I am missing something?Thanks!