-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change search plugin regular expression to support non-latin characters #2242
Comments
Introduced by #1557 Contribution welcome |
hi @meteorlxy @alizadeh118 |
Hey, I just reviewed your solution. That may break current logic for English words. I just made an alternative PR #2283 for this. |
Hi @meteorlxy As my test, nothing was broken. |
@meteorlxy Is it incorrect? |
Before your change, it won't match ready. It's the logic for English word in #1557 |
Thank you, I understand that it didn't match I read #1557, I view the improvement is
not relate fuzzy query. BTW, Could we support |
Feature request
What problem does this feature solve?
This add non-latin support for search plugin.
What does the proposed API look like?
It's not going to change API.
How should this be implemented in your opinion?
Now search plugin use this regex:
(?=.*\bWORD\b)
and it works for latin words but not for non-latin ones and this is about\b
word boundaries.We can use this alternative way to support both latin and non-latin characters:
(?=.*(?<=\s|^)WORD(?=\s|$))
Are you willing to work on this yourself?
Yes.
The text was updated successfully, but these errors were encountered: