Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in console about deeply nested sidebar #2190

Closed
1 task done
KieranHunt opened this issue Feb 18, 2020 · 3 comments
Closed
1 task done

Errors in console about deeply nested sidebar #2190

KieranHunt opened this issue Feb 18, 2020 · 3 comments
Labels
has PR Has a related PR type: bug Something isn't working

Comments

@KieranHunt
Copy link
Contributor

KieranHunt commented Feb 18, 2020

  • I confirm that this is an issue rather than a question.

Bug report

Steps to reproduce

Have sidebar that is nested more than 3 items deep.

What is expected?

No errors in the console output.

What is actually happening?

Errors on first page load and on navigating between pages.

Other relevant information

Found the line here:

if (groupDepth > 3) {
console.error(
'[vuepress] detected a too deep nested sidebar group.'
)
}

Reading through that code, it seems that VuePress doesn't really have an issue with nesting deeper than three. It just errors into the console and then continues.

Is there some context that I'm missing? I see that the change happened here: 01dd45b
But 3 seems pretty arbitrary.

Actual error message:

07:58:13.598 [vuepress] detected a too deep nested sidebar group. 2 2.258cb917.js:1:3364
KieranHunt added a commit to KieranHunt/vuepress that referenced this issue Feb 18, 2020
This arbitrarily logged out when nesting was greater than 3.

```
07:58:13.598 [vuepress] detected a too deep nested sidebar group. 2 2.258cb917.js:1:3364
```

vuejs#2190
@KieranHunt
Copy link
Contributor Author

Created a pull request for this here: #2191

@kefranabg kefranabg added type: bug Something isn't working has PR Has a related PR labels Feb 18, 2020
@Mister-Hope
Copy link
Contributor

It's designed by @ulivz , which warns people that his sidebar are to deep.

Just it, A too deep nested sidebar may have a bad apprence while rendering.

@KieranHunt
Copy link
Contributor Author

PR was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has PR Has a related PR type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants