Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@vuepress/pwa 无法弹出 updatePopup #2172

Closed
nuochong opened this issue Feb 7, 2020 · 12 comments · Fixed by #2187 · May be fixed by adamlaska/osmos-cosmos-sdk#5
Closed

@vuepress/pwa 无法弹出 updatePopup #2172

nuochong opened this issue Feb 7, 2020 · 12 comments · Fixed by #2187 · May be fixed by adamlaska/osmos-cosmos-sdk#5
Labels
has PR Has a related PR has workaround Has a workaround topic: plugins Relates to VuePress plugins type: bug Something isn't working

Comments

@nuochong
Copy link
Contributor

nuochong commented Feb 7, 2020

在更新Chrome浏览器后打包上线后无法显示更新对话框 updatePopup

·sw-updated· 无法被触发

VuePress官网也存在该情况

有关参数
···
chrome浏览器版本 80.0.3987.87(正式版本) (64 位)
"@vuepress/plugin-pwa": "^1.2.0",
"vuepress": "^1.2.0",
···

@haoranpb
Copy link
Contributor

haoranpb commented Feb 7, 2020

@nuochong Thanks for the report.
Please use English next time so everyone could understand and help you.


Translation:

@vuepress/plugin-pwa stop showing popup after updating Chrome

sw-updated can't be triggered

This is also happening on VuePress official document site.

Relevant information

Chrome 80.0.3987.87 (64-bit)
"@vuepress/plugin-pwa": "^1.2.0",
"vuepress": "^1.2.0",

@kefranabg
Copy link
Collaborator

If you've updated Chrome, you've probably reloaded your VuePress website and get the latest version, this is why the popup does not show up anymore. Feel free to comment you think something is uncorrect. Thanks @ludanxer for the translation 👍

@wwavelet
Copy link

wwavelet commented Feb 8, 2020

在更新Chrome浏览器后打包上线后无法显示更新对话框 updatePopup

·sw-updated· 无法被触发

VuePress官网也存在该情况

有关参数
···
chrome浏览器版本 80.0.3987.87(正式版本) (64 位)
"@vuepress/plugin-pwa": "^1.2.0",
"vuepress": "^1.2.0",
···

I also can't see the refresh button popup when I set {updatePopup:true}, but sw-updated works to me,as the docs say, you must close all the client, webpage tabs and installed application window then open the page again and you will see the updated content.

@daiwa233
Copy link

I also can't see the refresh button popup when I set {updatePopup:true}

@kefranabg kefranabg reopened this Feb 15, 2020
@wuyuehui
Copy link

I can't see the popup either,but the browser console prompt me Content was updated.
Unless I force the browser cache to clear, new content will appear.

@daiwa233
Copy link

I can't see the popup either,but the browser console prompt me Content was updated.
Unless I force the browser cache to clear, new content will appear.

we got the same question

@kefranabg
Copy link
Collaborator

Indeed.

The bug was introduced by this commit 6f9e478

@meteorlxy could you take a look?

@kefranabg kefranabg added type: bug Something isn't working topic: plugins Relates to VuePress plugins labels Feb 16, 2020
@meteorlxy
Copy link
Member

Sure

@meteorlxy
Copy link
Member

Figured out the reason.

The default options are set in ready() hook, which will have no effect in globalUIComponents option.

Fix and make further refactor in #2187

@meteorlxy meteorlxy added the has PR Has a related PR label Feb 17, 2020
@meteorlxy
Copy link
Member

meteorlxy commented Feb 17, 2020

For someone who wants a workaround:

Set popupComponent: 'SWUpdatePopup' option to make the popup component work in current version.

@meteorlxy meteorlxy added the has workaround Has a workaround label Feb 17, 2020
@kefranabg
Copy link
Collaborator

Awesome, thanks @meteorlxy 👍

@kefranabg
Copy link
Collaborator

Will be in the next minor release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has PR Has a related PR has workaround Has a workaround topic: plugins Relates to VuePress plugins type: bug Something isn't working
Projects
None yet
7 participants