-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report base URL in analytics plugin #2169
Labels
type: bug
Something isn't working
Comments
Nice catch! |
Is there any workaround before this is merged/released? |
mkfsn
added a commit
to mkfsn/blog
that referenced
this issue
Jul 20, 2020
18 tasks
meteorlxy
pushed a commit
that referenced
this issue
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report
When using Google Analytics plugin, the base Url configured in the config.js file is not returned by the plugin.
It seems that a fix for this was introduced in v0.14.4 which is not carried over to version 1.x.x. --> fix | current 0.x file.
Compare that to the current file in 1.x: enhanceAppFile.js
It seems that the only change required might be the following:
Steps to reproduce
Implement GA plugin in your project with a
config.base
value configured.What is expected?
The base URL is returned by the plugin.
What is actually happening?
The base URL is only returned when accessing pages from outside the VuePress site but not when navigating between pages on the VuePress site itself.
Other relevant information
npx vuepress info
in my VuePress project:The text was updated successfully, but these errors were encountered: