-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vuepress should fail if imported code snippets is not found #1872
Vuepress should fail if imported code snippets is not found #1872
Comments
Can I work on this? |
@ivandevp sure ! |
Hey guys! I've created a PR with the changes I'm making for this issue (#1910). I want your suggestions on this. By this moment, I've added the logger to show an error in the building process but, it won't stop the process. I haven't found a way to throw an error in other plugins used in the codebase, so I would like to know if you have an idea of how it should be. Let me know your thoughts, please. |
Hi @ivandevp, let's discuss this in your PR 😉 |
Feature request
What problem does this feature solve?
Currently, when trying to import a code snippet from a non-existing file, vuepress will create a snippet that says "File not found".
Input:
Output:
This is a problem because it results in broken documentation. In a CI/CD environment it would be great to surface this problem early.
What does the proposed API look like?
Vuepress should fail to render if a code snippet isn't found.
How should this be implemented in your opinion?
Are you willing to work on this yourself?
The text was updated successfully, but these errors were encountered: