-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: search box max suggestions not working as expected #1728
Conversation
I'm trying changing max suggestions like the link https://vuepress.vuejs.org/default-theme-config/#search-box But it was not work. I fix this bug.
Hello @vrjuliao ! Thank's for the PR Maybe it's more a bug coming into the constant. I will have a look at it soon. |
Hi @vrjuliao, Thanks for this PR 👍 |
adding a absent semicolon
hi @kefranabg, thanks for your suggestion. But, I didn't change the code formatting, I've just changed one line of code. Now, I trying to resolve the conflicts and I see so many changes. |
The code formating changes are made in this commit The changes are not made by me, but I'm attending you solicitation. |
@vrjuliao Ok ! @f3ltron could you take a look ? |
fix: pointer 'this' on searchBox is and commit name
There is some code formating and it look's good to me for stylus i pref to have {} instead of nothing for readability. a key not present in for loop. The thing i should not add that the "". But it will be corrected with the linter. I valid this pr |
thx @vrjuliao for your work 👍 |
Hey @vrjuliao, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
I'm trying changing max suggestions like the link
https://vuepress.vuejs.org/default-theme-config/#search-box
But it was not work.
I fix this bug.
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: