-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use semantic HTML in default theme #1154
Comments
Sounds good for a PR! |
18 tasks
Pull request opened 😊 |
HerrBertling
added a commit
to HerrBertling/vuepress
that referenced
this issue
Jan 3, 2019
ulivz
pushed a commit
that referenced
this issue
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature request
I'd like to improve the default theme by using some semantic HTML tags in favor of
div
s throughout the default theme.What problem does this feature solve?
This would make the default vuepress theme (and thus quite some documentation pages) a bit more accessible.
What does the proposed API look like?
It's not really an API, I just found some places in the theme that could use
main
,aside
orfooter
instead of a simplediv
. For example:footer
heremain
hereaside
hererole="search"
heresection
hereheader
hereI'm not sure whether I'd touch the navbar navigation parts. I'd prefer
li
s instead of adiv
per.nav-item
, but I'm aware that this change would require way more cross-device/env testing than the "simple quick wins" by exchanging some tags.How should this be implemented in your opinion?
I'd open a pull request if this is something of interest?
Are you willing to work on this yourself?**
See above :)
By the way: I thought about this some time ago and this article reminded me of that, so I figured I'd ask :)
The text was updated successfully, but these errors were encountered: