fix(component): clean up memory leak after loading async component completes (fix #8740) #8755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattlavallee
changed the title
mattlavallee
commented
Sep 4, 2018
| @@ -457,7 +457,7 @@ if (!isIE9) { | |||
| setTimeout(() => { | |||
| resolve({ template: '<div><h1>component B</h1></div>' }) | |||
| Vue.nextTick(next) | |||
| }, (duration + buffer) * 1.5) | |||
| }, (duration + buffer) * 1.7) | |||
There was a problem hiding this comment.
I was noticing timing issues while running the vue tests on my laptop locally. This test would pass if part of the entire suite, but if it was marked as a focused test, it would fail due to timing issues. I encountered this with the code prior to my change as well
mattlavallee
changed the title
wa3l
reviewed
Sep 5, 2018
| } | ||
|
|
||
| const currContext = contexts[i] | ||
| const contextIdx = contexts.indexOf(currContext) |
There was a problem hiding this comment.
@wa3l - good catch. The correct value of i is preserved when used in $nextTick if I just assign it to contextIdx.
I have updated the diff to include this refactor
mattlavallee
force-pushed
the
fix/async-component/memory-leak
branch
from
256a035
to
b7d0b80
Compare
|
是是是 |
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
…mpletes (fix vuejs#8740) (vuejs#8755) * fix(component): clean up memory leak after loading async component completes * fix(async component): accounting for async components with loading property * refactor(component): simplifying memory cleanup logic
aJean
pushed a commit
to aJean/vue
that referenced
this pull request
Aug 19, 2020
…mpletes (fix vuejs#8740) (vuejs#8755) * fix(component): clean up memory leak after loading async component completes * fix(async component): accounting for async components with loading property * refactor(component): simplifying memory cleanup logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: