Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check js assets more accurate in ssr webpack plugin #8639

Merged
merged 1 commit into from
Nov 30, 2018

Conversation

clarkdo
Copy link
Contributor

@clarkdo clarkdo commented Aug 11, 2018

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

If we config chunkName as '[name].js?v=[chunkhash]', the previous regex cannot match the js assets in webpack plugin, so use isJS to perfect match files

Pr will aslo resove nuxt/nuxt#3387

@yyx990803 yyx990803 merged commit 5624278 into vuejs:dev Nov 30, 2018
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants