Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v-pre): skip compiling custom component tags in v-pre blocks (fix… #8376

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

haoqunjiang
Copy link
Member

#8286)

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Turns out to be an easy fix…
Never thought the root cause could be in codegen and wasted a lot of time diving into vdom 😂.

A side effect of this fix is that every descendent component in a v-pre block would also carry a { pre: true } property.

@tyurderi
Copy link

c'mon approve and merge this fix please 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants