Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): injections should not always reactive #(5913) #6060

Closed
wants to merge 1 commit into from

Conversation

Kingwl
Copy link
Member

@Kingwl Kingwl commented Jul 9, 2017

fix #5913

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@Kingwl Kingwl requested a review from LinusBorg July 9, 2017 02:55
@yyx990803
Copy link
Member

Thanks - see 8d66691 we can use the observerState.shouldConvert flag to disable recursive conversion when using defineReactive (also used when initializing props).

@yyx990803 yyx990803 closed this Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

injected objects are reactive (despite documentation saying the opposite)
2 participants