Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toString utils should unref the Ref<T> #12888

Closed

Conversation

enpitsuLin
Copy link

fix #12884

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@enpitsuLin
Copy link
Author

Vue3 has a replacer parameter in JSON.stringify that call in toDisplayString but as same purpose toString doesn't

I'm not sure if I need to add that parameter or just do unref for Ref<T>

@LingRen
Copy link

LingRen commented Mar 27, 2023

don't depend v3, use type

@yyx990803 yyx990803 closed this in ae3e4b1 Dec 6, 2023
@yyx990803
Copy link
Member

  • It should use replacer, otherwise it won't unwrap nested refs.
  • It should not depend on v3, as it causes a circular dependency and causes runtime errors in the built version of Vue.
    See ae3e4b1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue2.7 和 Vue3 使用 toRefs 时表现不同。
3 participants