Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(core): getType uses a cache for well known types. #12123

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

perf(core): getType uses a cache for well known types. #12123

wants to merge 1 commit into from

Commits on Mar 6, 2023

  1. perf(core): getType uses a cache for well known types. 

    getType is called a lot, and it just run the same regexp over and over
on the same base types.
A cache increase its own efficiency by more than 80% for basic types.
On a real world application with a lot of components,
getType was profiled for 8% of call duration before this patch,
and about 0.5% after.
The impact is more limited for smaller applications.
    @Glandos
    Glandos committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    f06f110 View commit details
    Browse the repository at this point in the history