-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ssr): vue-ssr-webpack-plugin compatible with webpack 4/5 #11863
Conversation
+1 really need this |
Can this be merged? |
} | ||
// Webpack >= 5.0.0 | ||
else if (compiler.options.output.library && compiler.options.output.library.type !== 'commonjs2') { | ||
warn('webpack config `output.libraryTarget` should be "commonjs2".') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
output.library.type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blake-newman According to the webpack 5 documentation, I dont think output.library.type
is what's required in the webpack config.
The config supports output.libraryTarget: 'commonjs2'
as until now.
Indeed, the logic here should read the value from library.type
(I haven't checked, trusting the author on this one), but the warning to users needs to mention the proper webpack config - which is still output.libraryTarget
.
Waiting for update |
what about making these changes on vue-server-renderer/server-plugin.js? |
Co-authored-by: Lachlan Miller <[email protected]>
close #11718
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: