Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): changed expression type to optional string #11189

Merged
merged 1 commit into from
Mar 30, 2021
Merged

fix(types): changed expression type to optional string #11189

merged 1 commit into from
Mar 30, 2021

Conversation

kawokas
Copy link
Contributor

@kawokas kawokas commented Mar 8, 2020 •
edited
Loading

I changed expression type to optional string

fix #10871

it seems stopped since December ... so i try it 🙌
please point out if i have any deficiencies 🙏

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: types

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@posva posva removed the semver:minor label Sep 4, 2020
@posva posva changed the title types(v-node-directive): changed expression type to optional string(fix #10871) types(v-node-directive): changed expression type to optional string Feb 24, 2021
@posva posva changed the title types(v-node-directive): changed expression type to optional string types: changed expression type to optional string Feb 24, 2021
@posva posva changed the title types: changed expression type to optional string types(vnode): changed expression type to optional string Feb 24, 2021
@posva posva changed the title types(vnode): changed expression type to optional string fix(types): changed expression type to optional string Mar 30, 2021
@posva posva merged commit 7c75462 into vuejs:dev Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VNodeDirective expression Typing
2 participants
@kawokas @posva